-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding data masking cmdlets and refactoring to create a framework for AzureSql cmdlets #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Updated Stream Analytics SDK reference to the 0.16.0-preview version which corresponds to the 2015-01-01-preview Stream Analytics Service API Version - Integrated PowerShell cmdlets with the new features of the latest SDK. Most PowerShell cmdlets were already integrated since the new properties can be specified in the json file parameter. The most notable change was the addition of the OutputStartMode and OutputStartTime parameters in the StartAzureStreamAnalyticsJob cmdlet. - Re-recorded the tests and updated the session records.
Update Stream Analytics PowerShell To Use Latest SDK
Adding data masking cmdlets and refactoring of auditing cmdlets
Conflicts: src/ResourceManager/Sql/Commands.Sql.Test/Commands.Sql.Test.csproj src/ResourceManager/Sql/Commands.Sql.Test/packages.config src/ResourceManager/Sql/Commands.Sql/Commands.Sql.csproj src/ResourceManager/Sql/Commands.Sql/Security/Cmdlet/SqlCmdletBase.cs src/ResourceManager/Sql/Commands.Sql/Security/Services/AzureEndpointsCommunicator.cs src/ResourceManager/Sql/Commands.Sql/Security/Services/SqlClient.cs src/ResourceManager/StreamAnalytics/Commands.StreamAnalytics.Test/packages.config
Hi @yoavrubin, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
<add key="disableSourceControlIntegration" value="true" /> | ||
</solution> | ||
</configuration> | ||
<configuration> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use these packages anymore please reverse this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not done - this would disappear if it was done :-). Please add the commit for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure why, looks the same content-wise
|
||
protected override bool WriteResult() { return PassThru; } | ||
|
||
protected override DatabaseAuditingPolicyModel UpdateModel(DatabaseAuditingPolicyModel model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please comment all the methods and properties in the cmdlets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Adding data masking cmdlets and refactoring
No description provided.