Skip to content

Hongtu/change fabricbot.json #20567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

greathongtu
Copy link
Contributor

@greathongtu greathongtu commented Jan 4, 2023

Description

  • Use powershell to sort taskType: scheduledAndTrigger part of fabricbot.json according to the table of Service-Team-Label-and-Contact-List.
    • It is sorted by labels name in ascending order.
    • So that we can create a pipeline in internal project to update this fabricbot.json automaticly further.
    • Add 27 new labels: Confidential Ledger, Consumption, Consumption- RIandShowBack ,Consumption-Billing, Consumption-Budget, Consumption-Consumption, Consumption-Query, Consumption-UsageDetailsandExport, Container App, Cost Management, Cost Management-Billing, Cost Management-Budget, Cost Management-Query, Cost Management-RIandShowBack, Cost Management-UsageDetailsAndExport, DataProtection, IotCentral, IotDPS, IotHub, MySQL - Flexible, Network - ExpressRoutes, PostgreSQL - Flexible, PowerBI, Quantum, Serial Console, Spring Cloud, WebPubSub
    • Remove 11 labels that don't exist in wiki page: Network - ExpressRoute, Cost Management - Budget, Cost Management - Query, Consumption - Query, Cost Management - Billing, Consumption - Billing, Cost Management - UsageDetailsAndExport, Consumption - UsageDetailsAndExport, Cost Management - RIandShowBack, Consumption - RIandShowBack, Consumption - Budget

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@dingmeng-xue
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dingmeng-xue dingmeng-xue merged commit f8d2f8a into Azure:main Jan 5, 2023
@greathongtu greathongtu deleted the hongtu/change_fabricbot.json branch January 19, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants