-
Notifications
You must be signed in to change notification settings - Fork 4k
Added Web Deploy change summary output #2071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @aneillans, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
Can one of the admins verify this patch? |
@azuresdkci test this please |
Bring up to date
Looks like the test failure exists in the core branch of dev. |
@azuresdkci test this please |
@aneillans dev branch does not have any build issue. It looks like you have introduced a new dependency in your PR. In that case you will have to regenerate setup\azurecmdfiles.wxi file. You can do that by running tools\BuildInstaller.ps1 file. |
@hovsepm Thanks for the info -- it's not a new dependency however - it's used by other assemblies in this package already, or is the tracking per assembly hence requiring the update? (Incidentally I can't see it being listed in the wxi file already). |
@aneillans assemblies are loaded per folder, so any new or removed dependencies in your project will require a wxi change. |
@aneillans You will need to make sure that this assembly is actually copied to the directory and that it is included in the wxi file. You can find instructions on regenerating the wxi file here: https://github.com/Azure/azure-powershell/wiki/Microsoft-Azure-PowerShell-Developer-Guide#updating-the-installer |
@aneillans Please respond, or we will have to close this pull request |
@markcowl apologies been backed up at work - will get to this hopefully this week. |
@markcowl Mark, I'm struggling to identify where this is actually failing - the assembly in question, Microsoft.Web.Deployment has not been added to any new locations that did not already reference it (Commands.Utilities and Commands) as such there should be no additional requirements to include any assemblies for the wxi file ? |
Updating fork to current
@azuresdkci add to whitelist |
@aneillans The project may have had a reference to Microsoft.Web.Deployment, but this is the first actual usage, so that first time that reference was actually carried into the dll. |
@markcowl thats just it - it must have been used as its how WebDeploy is actually implemented. I did not that there are records in the Exceptions files for the same errors. Wonder if they were being ignored? |
@aneillans The previous references were from the utility assembly, which includes web deploymwnt in packages.config. To fix this, please add the packages.config reference to Microsoft.Web.Deployment in the Commands package, and add in the exceptions for the new assembly. You will probably need to regenerate the wix file to have the assembly included. After this, we'll take a look to make sure the assembly is copied to all the necessary directories. |
@aneillans looks like some ytest failures in website projects |
@markcowl took a bit of experimentation to get the tests running locally; but think I've resolved them. Fingers crossed! |
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/803/ |
Part of issue #1095