Skip to content

[Release.1.3.2] Add backup and restore cmdlets for Azure Web Apps #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Apr 12, 2016
Merged

[Release.1.3.2] Add backup and restore cmdlets for Azure Web Apps #2073

merged 41 commits into from
Apr 12, 2016

Conversation

nking-1
Copy link

@nking-1 nking-1 commented Apr 9, 2016

Merge Azure Web Apps backup and restore cmdlets for release

Nicholas King added 30 commits December 7, 2015 13:36
Wrote first draft of all cmdlets for backup and restore
acf65ef
New commands added to csproj
ef3cff6
Moved new cmdlets to their own directory
bafcb8e
Sketched out the first test
f0b6fec
Sketched out a few more tests
cae5ac4
Wrote most of the tests and refactored a few things. Making a commit …
d4b08eb 
…before more extensive refactoring.
Refactored backup/restore cmdlets to inherit from a base class. Chang…
a401557 
…ed piping to be consistent with other websites cmdlets. Wrote tests for BackupConfiguration and Restore operations.
Bug fixes found by hand testing
5f2237c
Renamed cmdlets to use Rm instead of RM. Also added Restore cmdlet th…
febbe5a 
…at was getting ignored
Merge remote-tracking branch 'upstream/dev' into dev
90de3c9 
Conflicts:
	src/ResourceManager/Websites/Commands.Websites.Test/Commands.Websites.Test.csproj
	src/ResourceManager/Websites/Commands.Websites/Commands.Websites.csproj
	src/ResourceManager/Websites/Commands.Websites/Utilities/CmdletHelpers.cs
	src/ResourceManager/Websites/Commands.Websites/Utilities/WebsitesClient.cs
Merge remote-tracking branch 'upstream/dev' into dev
b4976df 
Conflicts:
	src/ResourceManager/Websites/Commands.Websites.Test/ScenarioTests/Common.ps1
Merge remote-tracking branch 'upstream/dev' into dev
ce231db
Merge remote-tracking branch 'upstream/dev' into dev
957d71c
Merge remote-tracking branch 'upstream/dev' into dev
1d56a68
Merge remote-tracking branch 'upstream/dev' into dev
eff9404
Prepare to rework tests to remove SQL database backup
28efb4a
Merge remote-tracking branch 'upstream/dev' into dev
e49ba8a
Merge remote-tracking branch 'upstream/dev' into dev
f04ed1c
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
8a34479
Wrote passing tests for WebSites backup
44a5191
Finished writing tests for backup/restore code
08762f6
Merge remote-tracking branch 'upstream/dev' into dev
6b1323b 
Conflicts:
	src/ResourceManager/Websites/Commands.Websites.Test/packages.config
Merge remote-tracking branch 'upstream/dev' into dev
76a95c0
WebAppBackup tests will now pass in playback mode
5d1b6b5
Cleaned up test and project files
cba2807
Added copyright headers to *.cs files
cbd5925
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
aba2532
Rewrote the web app backup and restore cmdlets to allow more convenie…
ac6b51f 
…nt piping
Rewrote tests to match new piping semantics
bd4037e
Deleted Remove-AzureRmWebAppBackupConfiguration cmdlet due to bugs in…
0713f24 
… App Service
@azurecla
Copy link

azurecla commented Apr 9, 2016

Hi @Nking92, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (nicking). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm
Copy link
Contributor

hovsepm commented Apr 11, 2016

Link to previous PR with code review comments #1974

@hovsepm
Copy link
Contributor

hovsepm commented Apr 11, 2016

on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/666/

@hovsepm hovsepm changed the title Release.1.3.2 [Release.1.3.2] Add backup and restore cmdlets for Azure Web Apps Apr 11, 2016
@hovsepm
Copy link
Contributor

hovsepm commented Apr 11, 2016

@Nking92 wxi changes seems not required. Please revert that.

Revert "Regenerate wxi file"
51cd62f 
This reverts commit cd537d3.
@hovsepm
Copy link
Contributor

hovsepm commented Apr 11, 2016

new on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/667/

markcowl
markcowl reviewed Apr 11, 2016
View reviewed changes
src/ResourceManager/Websites/Commands.Websites/Cmdlets/BackupRestore/BackupRestoreUtils.cs
@@ -0,0 +1,100 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright header

@markcowl
Copy link
Member

@Nking92 A few comments - this looks really good other than a couple of cosmetic changes.

Nicholas King added 2 commits April 11, 2016 13:35
@nking-1
Copy link
Author

nking-1 commented Apr 11, 2016

@markcowl Thanks for the code review. I have addressed your comments in the latest commits.

@nking-1
Copy link
Author

nking-1 commented Apr 11, 2016

new on-demand job started http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/672/

@hovsepm
Copy link
Contributor

hovsepm commented Apr 11, 2016

new on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/675/

@hovsepm hovsepm merged commit b32ee4f into Azure:Release.1.3.2 Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nking-1 @azurecla @hovsepm @markcowl