Skip to content

Fix the issue of wrong format of csv #20765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Fix the issue of wrong format of csv #20765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ac9fb1
Fix the issue of wrong format of csv
wyunchi-ms Jan 29, 2023
bc9e951
Fix the issue of wrong format of csv
wyunchi-ms Jan 29, 2023
e4b402a
Suppress Az.Compute
wyunchi-ms Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,7 @@
"Az.Compute","Get-AzVmssVMRunCommand","Get-AzVmssVMRunCommand","0","1050","The parameter set 'GetViaIdentity' for cmdlet 'Get-AzVmssVMRunCommand' has been removed.","Add parameter set 'GetViaIdentity' back to cmdlet 'Get-AzVmssVMRunCommand'."
"Az.Compute","Get-AzVmssVMRunCommand","Get-AzVmssVMRunCommand","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Get-AzVmssVMRunCommand' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Get-AzVmssVMRunCommand'."
"Az.Compute","Get-AzVmssVMRunCommand","Get-AzVmssVMRunCommand","0","1000","The cmdlet 'Get-AzVmssVMRunCommand' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'Get-AzVmssVMRunCommand' back to the module, or add an alias to the original cmdlet name."
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRmGalleryImageVersion","Get-AzGalleryImageVersion","0","3000","The type of property 'Source' of type 'Microsoft.Azure.Management.Compute.Models.GalleryImageVersionStorageProfile' has changed from 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource' to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionFullSource'.","Change the type of property 'Source' back to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource'."
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRmGalleryImageVersion","Get-AzGalleryImageVersion","0","3000","The type of property 'Source' of type 'Microsoft.Azure.Management.Compute.Models.GalleryOSDiskImage' has changed from 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource' to 'Microsoft.Azure.Management.Compute.Models.GalleryDiskImageSource'.","Change the type of property 'Source' back to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource'."
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.GetAzureRmGalleryImageVersion","Get-AzGalleryImageVersion","0","3000","The type of property 'Source' of type 'Microsoft.Azure.Management.Compute.Models.GalleryDataDiskImage' has changed from 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource' to 'Microsoft.Azure.Management.Compute.Models.GalleryDiskImageSource'.","Change the type of property 'Source' back to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource'."
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmGalleryImageVersion","New-AzGalleryImageVersion","0","3000","The type of property 'Source' of type 'Microsoft.Azure.Management.Compute.Models.GalleryOSDiskImage' has changed from 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource' to 'Microsoft.Azure.Management.Compute.Models.GalleryDiskImageSource'.","Change the type of property 'Source' back to 'Microsoft.Azure.Management.Compute.Models.GalleryArtifactVersionSource'."
9 changes: 4 additions & 5 deletions tools/StaticAnalysis/Exceptions/Az.Storage/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet.CopyAzureStorageBlob","Copy-AzStorageBlob","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Copy-AzStorageBlob'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.SetAzureBlobContentCommand","Set-AzStorageBlobContent","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Set-AzStorageBlobContent'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet.StartAzureStorageBlobCopy","Start-AzStorageBlobCopy","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Start-AzStorageBlobCopy'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."

"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet.CopyAzureStorageBlob","Copy-AzStorageBlob","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Copy-AzStorageBlob'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.SetAzureBlobContentCommand","Set-AzStorageBlobContent","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Set-AzStorageBlobContent'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
"Az.Storage","Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet.StartAzureStorageBlobCopy","Start-AzStorageBlobCopy","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'StandardBlobTier' for cmdlet 'Start-AzStorageBlobCopy'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'StandardBlobTier'."
7 changes: 6 additions & 1 deletion tools/Tools.Common/Loggers/ReportLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,13 @@ public ReportLogger(string fileName, string exceptionsFileName, AnalysisLogger l
var records = File.ReadAllLines(exceptionsFileName);
for (int i = 1; i < records.Length; ++i)
{
string recordContent = records[i].Trim();
if (recordContent == "")
{
continue;
}
var record = new T();
_exceptionRecords.Add(record.Parse(records[i]) as T);
_exceptionRecords.Add(record.Parse(recordContent) as T);
}
}
}
Expand Down