Skip to content

Add import/export cmdlets for Azure Sql database #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 19, 2016
Merged

Add import/export cmdlets for Azure Sql database #2077

merged 6 commits into from
Apr 19, 2016

Conversation

llali
Copy link
Contributor

@llali llali commented Apr 11, 2016

Add import/export and get status cmdlets for Azure Sql database. Please review and merge. Thanks

@azurecla
Copy link

Hi @llali, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (llali). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci
Copy link

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor

hovsepm commented Apr 11, 2016

@azuresdkci add to whitelist

hovsepm
hovsepm reviewed Apr 11, 2016
View reviewed changes
src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/Common.ps1
function Get-SqlDatabaseImportExportTestEnvironmentParameters ($testSuffix)
{
$databaseName = "sql-ie-cmdlet-db" + $testSuffix;
$password = "Testp@ssw0rd";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llali you should not hardcode passwords.

@hovsepm
Copy link
Contributor

hovsepm commented Apr 11, 2016

  • Help missing for cmdlet Get-AzureRmSqlDatabaseImportExportStatus implemented by class Microsoft.Azure.Commands.Sql.ImportExport.Cmdlet.GetAzureSqlDatabaseImportExportStatus
  • Help missing for cmdlet New-AzureRmSqlDatabaseExport implemented by class Microsoft.Azure.Commands.Sql.ImportExport.Cmdlet.NewAzureSqlDatabaseExport
  • Help missing for cmdlet New-AzureRmSqlDatabaseImport implemented by class Microsoft.Azure.Commands.Sql.ImportExport.Cmdlet.NewAzureSqlDatabaseImport

@markcowl
Copy link
Member

@azuresdkci retest this please

markcowl
markcowl reviewed Apr 18, 2016
View reviewed changes
...esourceManager/Sql/Commands.Sql/ImportExport/Cmdlet/GetAzureSqlDatabaseImportExportStatus.cs
/// <summary>
/// Defines the AzureRmSqlDatabaseImportExportStatus cmdlet
/// </summary>
[Cmdlet(VerbsCommon.Get, "AzureRmSqlDatabaseImportExportStatus", ConfirmImpact = ConfirmImpact.Low)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ConfirmImpact.Low? Using ConfirmImpact.Medium avoids prompts. Also, you don't want this setting without SupportsShouldProcess=true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@markcowl
Copy link
Member

@llali a few comments on the cmdlet signatures. These are suggestions, but are not yet required

@llali
renamed DatabaseMaxSize to DatabaseMaxSizeBytes
d7c7597 
Changed the ConfirmImpact to Medium and added SupportsShouldProcess = true
@markcowl
Copy link
Member

@azuresdkci retest this please

@hovsepm hovsepm merged commit c8bbdda into Azure:dev Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@llali @azurecla @azuresdkci @hovsepm @markcowl