Skip to content

change storage account link #20851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

yadongyaly
Copy link

@yadongyaly yadongyaly commented Feb 3, 2023

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@ghost ghost added the customer-reported label Feb 3, 2023
@ghost
Copy link

ghost commented Feb 3, 2023

Thank you for your contribution yadongyaly! We will review the pull request and get back to you soon.

@yadongyaly
Copy link
Author

This is tiny change of updating the storage account link.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Feb 6, 2023

Are you from service team? @yadongyaly If yes, please let your github account join Azure org.

@BethanyZhou BethanyZhou added the needs-author-feedback More information is needed from author to address the issue. label Feb 6, 2023
@yadongyaly
Copy link
Author

Are you from service team? @yadongyaly If yes, please let your github account join Azure org.

Yes, I am from service team. I think I have joined the Azure org when I created the last PR of adding this function. Does it show I am not in Azure org?

@BethanyZhou
Copy link
Contributor

Yes. Your profile shows you are not in any org. Please join Azure org if possible.

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethanyZhou BethanyZhou merged commit 35a60b4 into Azure:generation Feb 6, 2023
@BethanyZhou
Copy link
Contributor

@yadongyaly please help update change log for this PR #20857

@yadongyaly
Copy link
Author

@yadongyaly please help update change log for this PR #20857
Hi @BethanyZhou, sorry I could not find the change log file. Will this work?

Change log:
Update the link of storage account for users to download LoginsMigration.zip file.

@BethanyZhou
Copy link
Contributor

Sure. Thank you for the information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported needs-author-feedback More information is needed from author to address the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants