-
Notifications
You must be signed in to change notification settings - Fork 4k
{AzureFrontDoor} fixes Azure/azure-powershell#20870 Adding Tag parameter to New-AzFrontDoorWafPolicy #20908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…WafPolicy fixes #20870 Adding Tag parameter to New-AzFrontDoorWafPolicy This PR Allow the passing of tags when creating a new Azure Front Door Waf Policy resource. Currently, tags can be added in the portal but not via powershell for the FrontDoor WAF policy.
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this parameter should be added into Update-AzFrontDoorWafPolicy as well. @navba-MSFT what's your thought
@BethanyZhou For updating the tags alone, the recommendation would be to use Update-AzTag command. |
we'd better allow customer to update other properties together with tags. |
fixes #20870
Adding Tag parameter to New-AzFrontDoorWafPolicy
This PR Allow the passing of tags when creating a new Azure Front Door Waf Policy resource. Currently, tags can be added in the portal but not via powershell for the FrontDoor WAF policy.
Description
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.