Skip to content

[Release.1.3.2-rc3] Add warning message to ARM cmdlets in Resources projects, indicating … #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public void TestRemoveDeployment()
ResourcesController.NewInstance.RunPsTest("Test-RemoveDeployment");
}

[Fact]
[Fact(Skip = "Doesn't add any value. Will improve negative tests in a future release")]
public void TestGetNonExistingResourceGroupWithDebugStream()
{
ResourcesController.NewInstance.RunPsTest("Test-GetNonExistingResourceGroupWithDebugStream");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ public class GetAzureProviderFeatureCmdlet : AzureProviderFeatureCmdletBase

public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
var parameterSetName = this.DetermineParameterSetName();

switch (parameterSetName)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public class RegisterAzureProviderFeatureCmdlet : AzureProviderFeatureCmdletBase
/// </summary>
public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
this.ConfirmAction(
force: this.Force,
actionMessage: string.Format(ProjectResources.RegisteringProviderFeature, this.FeatureName, this.ProviderNamespace),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ public class GetAzureProviderCmdlet : ResourcesBaseCmdlet
/// </summary>
public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
var providers = this.ResourcesClient.ListPSResourceProviders(providerName: this.ProviderNamespace, listAvailable: this.ListAvailable, location: this.Location);

if (!string.IsNullOrEmpty(this.ProviderNamespace))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public class GetAzureProviderOperationCommand : ResourcesBaseCmdlet
/// </summary>
public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
// remove leading and trailing whitespaces
this.OperationSearchString = this.OperationSearchString.Trim();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public class RegisterAzureProviderCmdlet : ResourcesBaseCmdlet
/// </summary>
public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
this.ConfirmAction(
force: this.Force,
actionMessage: string.Format(ProjectResources.RegisteringProvider, this.ProviderNamespace),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public class UnregisterAzureProviderCmdlet : ResourcesBaseCmdlet
/// </summary>
public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
this.ConfirmAction(
force: this.Force,
actionMessage: string.Format(ProjectResources.UnregisteringProvider, this.ProviderNamespace),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public class GetAzureResourceGroupDeploymentCommand : ResourcesBaseCmdlet

public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
FilterResourceGroupDeploymentOptions options = new FilterResourceGroupDeploymentOptions()
{
ResourceGroupName = ResourceGroupName ?? ResourceIdUtility.GetResourceGroupName(Id),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public NewAzureResourceGroupDeploymentCommand()

public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
CreatePSResourceGroupDeploymentParameters parameters = new CreatePSResourceGroupDeploymentParameters()
{
ResourceGroupName = ResourceGroupName,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ public class GetAzureResourceGroupCommand : ResourcesBaseCmdlet, IModuleAssembly

public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
Name = Name ?? ResourceIdentifier.FromResourceGroupIdentifier(this.Id).ResourceGroupName;

this.WriteObject(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public class NewAzureResourceGroupCommand : ResourcesBaseCmdlet

public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
CreatePSResourceGroupParameters parameters = new CreatePSResourceGroupParameters
{
ResourceGroupName = Name,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public class SetAzureResourceGroupCommand : ResourcesBaseCmdlet

public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
UpdatePSResourceGroupParameters parameters = new UpdatePSResourceGroupParameters
{
ResourceGroupName = Name ?? ResourceIdentifier.FromResourceGroupIdentifier(this.Id).ResourceGroupName,
Expand Down