Skip to content

[Release.1.3.2-rc2] [AzureRT] #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2016
Merged

[Release.1.3.2-rc2] [AzureRT] #2101

merged 5 commits into from
Apr 14, 2016

Conversation

hyonholee
Copy link
Contributor

  • Add ApplicationGatewayBackendAddressPoolsId parameter to New-AzureRmVmssIpConfig cmdlets
  • Fix localization issue of New-AzureRmVM
  • Remove InvokeAzureComputeMethod, New-AzureComputeArgumentList, New-AzureComputeParameterObject cmdlets

@hovsepm hovsepm changed the title [AzureRT] [Release.1.3.2-rc2] [AzureRT] Apr 14, 2016
@@ -30,7 +30,7 @@

namespace Microsoft.Azure.Commands.Compute.Automation
{
[Cmdlet(VerbsLifecycle.Invoke, "AzureComputeMethod", DefaultParameterSetName = "InvokeByDynamicParameters")]
//[Cmdlet(VerbsLifecycle.Invoke, "AzureComputeMethod", DefaultParameterSetName = "InvokeByDynamicParameters")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyonholee why do you have commented code here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file. We decided not to generate Invoke-AzureComputeMethod cmdlet, which is a general cmdlet for invoking any compute APIs. We modified our auto-generator such that it has an option to choose if it generates the cmdlet. If we don't want, the generator just comments out.

@hovsepm
Copy link
Contributor

hovsepm commented Apr 14, 2016

@hyonholee
Copy link
Contributor Author

Tests for the fix is done manually and automated tests will be added later.

@hovsepm hovsepm merged commit 8519c18 into Azure:Release.1.3.2 Apr 14, 2016
@hyonholee hyonholee deleted the dev3 branch April 14, 2016 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants