Skip to content

Fix a typo #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Fix a typo #2118

merged 1 commit into from
Apr 26, 2016

Conversation

yantang-msft
Copy link
Contributor

A simple fix for a typo.

@markcowl
Copy link
Member

@yantang-msft Is there some functionality this fixes? If so, can you please add or modify a test to prevent future regressions?

@yantang-msft
Copy link
Contributor Author

Is there some functionality this fixes? If so, can you please add or modify a test to prevent future regressions?

The functionality is the same. Just make the logic right for the type casting.

@markcowl
Copy link
Member

@yantang-msft The functionality is not the same. There are now cases where this code will not execute, and I want to make sure this is tested

@yantang-msft
Copy link
Contributor Author

The functionality is not the same. There are now cases where this code will not execute, and I want to make sure this is tested

The functionality for what we announced is the same. The code path that should execute still executes. The path that should not execute is now really prevented by the fix.
To create a test to verify such simple fix probably doesn't deserve the effort.

@hovsepm
Copy link
Contributor

hovsepm commented Apr 25, 2016

@yantang-msft
no need to add a new test - you can modify the existing one. Adding test coverage for bugfixes makes sure that your new feature works as designed. Plus it will be a gatekeeper for future code changes to exclude regression bugs.
Otherwise please explicitly sign-off on this fix and specify that tests here are not required.

@markcowl
Copy link
Member

@yantang-msft Looking at this again, the 'VM' property is not used anywhere in the code block, and any violation would throw at the second statement. I would still like to see coverage of this, as adequate testing should have prevented this issue in the first place, but won't gate this fix on it.

@markcowl
Copy link
Member

@markcowl markcowl merged commit 009b8a3 into Azure:dev Apr 26, 2016
@yantang-msft yantang-msft deleted the FixTypo branch November 13, 2017 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants