Skip to content

Update Set-AzureRmVMSqlServerExtension to remove infinite loop #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2016
Merged

Update Set-AzureRmVMSqlServerExtension to remove infinite loop #2124

merged 2 commits into from
Apr 26, 2016

Conversation

michaelcohenmicrosoft
Copy link
Contributor

No description provided.

@azurecla
Copy link

Hi @michaelcohenmicrosoft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (michco). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

markcowl
markcowl reviewed Apr 25, 2016
View reviewed changes
src/ResourceManager/Compute/Commands.Compute.Test/Commands.Compute.Test.csproj
@@ -243,6 +244,7 @@
<None Include="ScenarioTests\RunnerTests.csv">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="ScenarioTests\SqlIaaSExtensionTests.ps1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelcohenmicrosoft You need to add this, and the recorded mock to the csproj, and both should be marked as 'CopyAlways' or 'CopyIfNewer'

@michaelcohenmicrosoft
Copy link
Contributor Author

@hovsepm Tests have been added and are passing

@markcowl
Copy link
Member

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/699/

@hovsepm hovsepm merged commit 3315ae0 into Azure:dev Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelcohenmicrosoft @azurecla @markcowl @hovsepm