-
Notifications
You must be signed in to change notification settings - Fork 4k
[MSGraph] fix group member polymophism and add count variable for list #21760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VeryEarly
merged 10 commits into
generation
from
yabo/directoryobject-and-countvariable
May 11, 2023
Merged
[MSGraph] fix group member polymophism and add count variable for list #21760
VeryEarly
merged 10 commits into
generation
from
yabo/directoryobject-and-countvariable
May 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move application schema into commontypes.yml * support polymorphism for directoryobject * re-enable API version * add -CountVariable to list cmdlets * return when count or countvariable not provided, or consistencyLevel incorrect * return when count or countvariable not provided, or consistencyLevel incorrect * fix version for autorest/powershell dev and autorest/core
️✔️Az.Accounts
|
Type | Cmdlet | Description | Remediation |
---|---|---|---|
Get-AzADOrganization | Get-AzADOrganization Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzADOrganization | Get-AzADOrganization changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ 1 1 Unassigned_Variable Get-AzADGroup -DisplayName $gname is a null-valued parameter value. -DisplayName Assign value for $gname. ⚠️ 1 3 Unassigned_Variable Get-AzADUser -DisplayName $uname is a null-valued parameter value. -DisplayName Assign value for $uname. ⚠️ 1 4 Unassigned_Variable Get-AzADServicePrincipal -ApplicationId $appid is a null-valued parameter value. -ApplicationId Assign value for $appid. ⚠️ 1 1 Unassigned_Variable Get-AzADAppCredential -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Get-AzADApplication -ObjectId $app is a null-valued parameter value. -ObjectId Assign value for $app. ⚠️ 2 1 Unassigned_Variable Get-AzADAppFederatedCredential -ApplicationObjectId $appObjectId is a null-valued parameter value. -ApplicationObjectId Assign value for $appObjectId. ⚠️ 2 1 Unassigned_Variable Get-AzADAppFederatedCredential -FederatedCredentialId $credentialId is a null-valued parameter value. -FederatedCredentialId Assign value for $credentialId. ⚠️ 1 1 Unassigned_Variable Get-AzADApplication -DisplayName $appname is a null-valued parameter value. -DisplayName Assign value for $appname. ⚠️ 3 1 Unassigned_Variable Get-AzADApplication -DisplayNameStartsWith $prefix is a null-valued parameter value. -DisplayNameStartsWith Assign value for $prefix. ⚠️ 4 1 Unassigned_Variable Get-AzADApplication -ObjectId $id is a null-valued parameter value. -ObjectId Assign value for $id. ⚠️ 1 1 Unassigned_Variable Get-AzADGroup -DisplayName $gname is a null-valued parameter value. -DisplayName Assign value for $gname. ⚠️ 3 1 Unassigned_Variable Get-AzADGroup -ObjectId $id is a null-valued parameter value. -ObjectId Assign value for $id. ⚠️ 1 1 Unassigned_Variable Get-AzADGroupMember -GroupDisplayName $name is a null-valued parameter value. -GroupDisplayName Assign value for $name. ⚠️ 2 1 Unassigned_Variable Get-AzADGroup -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Get-AzADServicePrincipal -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 2 1 Unassigned_Variable Get-AzADServicePrincipal -DisplayNameStartsWith $prefix is a null-valued parameter value. -DisplayNameStartsWith Assign value for $prefix. ⚠️ 4 1 Unassigned_Variable Get-AzADServicePrincipal -ApplicationId $appId is a null-valued parameter value. -ApplicationId Assign value for $appId. ⚠️ 5 1 Unassigned_Variable Get-AzADApplication -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Get-AzADSpCredential -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 3 1 Unassigned_Variable Get-AzADUser -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 2 2 Unassigned_Variable Get-AzADApplication -ApplicationId $appId is a null-valued parameter value. -ApplicationId Assign value for $appId. ⚠️ 2 2 Unassigned_Variable New-AzADAppCredential -StartDate $startDate is a null-valued parameter value. -StartDate Assign value for $startDate. ⚠️ 2 2 Unassigned_Variable New-AzADAppCredential -EndDate $endDate is a null-valued parameter value. -EndDate Assign value for $endDate. ⚠️ 1 1 Unassigned_Variable New-AzADGroup -DisplayName $gname is a null-valued parameter value. -DisplayName Assign value for $gname. ⚠️ 1 1 Unassigned_Variable New-AzADGroup -MailNickname $nickname is a null-valued parameter value. -MailNickname Assign value for $nickname. ⚠️ 2 1 Unassigned_Variable New-AzADServicePrincipal -ApplicationId $appid is a null-valued parameter value. -ApplicationId Assign value for $appid. ⚠️ 3 1 Unassigned_Variable New-AzADServicePrincipal -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 6 Unassigned_Variable New-AzADSpCredential -ObjectId $Id is a null-valued parameter value. -ObjectId Assign value for $Id. ⚠️ 2 1 Unassigned_Variable Get-AzADServicePrincipal -ApplicationId $appId is a null-valued parameter value. -ApplicationId Assign value for $appId. ⚠️ 2 1 Unassigned_Variable New-AzADSpCredential -StartDate $startDate is a null-valued parameter value. -StartDate Assign value for $startDate. ⚠️ 2 1 Unassigned_Variable New-AzADSpCredential -EndDate $endDate is a null-valued parameter value. -EndDate Assign value for $endDate. ⚠️ 1 3 Unassigned_Variable New-AzADUser -DisplayName $uname is a null-valued parameter value. -DisplayName Assign value for $uname. ⚠️ 1 3 Unassigned_Variable New-AzADUser -MailNickname $nickname is a null-valued parameter value. -MailNickname Assign value for $nickname. ⚠️ 1 3 Unassigned_Variable New-AzADUser -UserPrincipalName $upn is a null-valued parameter value. -UserPrincipalName Assign value for $upn. ⚠️ 2 2 Mismatched_Parameter_Value_Type ConvertTo-SecureString -[-String] $password is not an expected parameter value type. $password Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command). ⚠️ 2 3 Unassigned_Variable New-AzADUser -DisplayName $uname is a null-valued parameter value. -DisplayName Assign value for $uname. ⚠️ 2 3 Unassigned_Variable New-AzADUser -MailNickname $nickname is a null-valued parameter value. -MailNickname Assign value for $nickname. ⚠️ 2 3 Unassigned_Variable New-AzADUser -UserPrincipalName $upn is a null-valued parameter value. -UserPrincipalName Assign value for $upn. ⚠️ 1 1 Unassigned_Variable Remove-AzADAppCredential -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Remove-AzADAppCredential -KeyId $keyid is a null-valued parameter value. -KeyId Assign value for $keyid. ⚠️ 2 1 Unassigned_Variable Get-AzADApplication -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Remove-AzADApplication -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 2 1 Unassigned_Variable Get-AzADApplication -ObjectId $id is a null-valued parameter value. -ObjectId Assign value for $id. ⚠️ 1 1 Unassigned_Variable Remove-AzADGroup -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 2 1 Unassigned_Variable Get-AzADGroup -ObjectId $id is a null-valued parameter value. -ObjectId Assign value for $id. ⚠️ 1 2 Unassigned_Variable Get-AzADUser -DisplayName $uname is a null-valued parameter value. -DisplayName Assign value for $uname. ⚠️ 1 3 Unassigned_Variable Get-AzADServicePrincipal -ApplicationId $appid is a null-valued parameter value. -ApplicationId Assign value for $appid. ⚠️ 1 4 Unassigned_Variable Get-AzADGroupMember -GroupDisplayName $gname is a null-valued parameter value. -GroupDisplayName Assign value for $gname. ⚠️ 1 4 Unassigned_Variable Remove-AzADGroupMember -MemberObjectId $member is a null-valued parameter value. -MemberObjectId Assign value for $member. ⚠️ 1 1 Unassigned_Variable Remove-AzADServicePrincipal -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 2 1 Unassigned_Variable Get-AzADServicePrincipal -ApplicationId $id is a null-valued parameter value. -ApplicationId Assign value for $id. ⚠️ 1 1 Unassigned_Variable Remove-AzADSpCredential -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Remove-AzADSpCredential -KeyId $keyid is a null-valued parameter value. -KeyId Assign value for $keyid. ⚠️ 2 1 Unassigned_Variable Get-AzADServicePrincipal -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Remove-AzADUser -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 2 1 Unassigned_Variable Get-AzADUser -UserPrincipalName $id is a null-valued parameter value. -UserPrincipalName Assign value for $id. ⚠️ 1 1 Unassigned_Variable Update-AzADApplication -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Update-AzADApplication -HomePage $homepage is a null-valued parameter value. -HomePage Assign value for $homepage. ⚠️ 2 1 Unassigned_Variable Get-AzADApplication -ObjectId $id is a null-valued parameter value. -ObjectId Assign value for $id. ⚠️ 2 1 Unassigned_Variable Update-AzADApplication -ReplyUrl $replyurl is a null-valued parameter value. -ReplyUrl Assign value for $replyurl. ⚠️ 1 1 Unassigned_Variable Update-AzADGroup -ObjectId $objectid is a null-valued parameter value. -ObjectId Assign value for $objectid. ⚠️ 1 1 Unassigned_Variable Update-AzADGroup -Description $description is a null-valued parameter value. -Description Assign value for $description. ⚠️ 1 1 Unassigned_Variable Update-AzADServicePrincipal -DisplayName $name is a null-valued parameter value. -DisplayName Assign value for $name. ⚠️ 1 1 Unassigned_Variable Update-AzADServicePrincipal -IdentifierUri $uri is a null-valued parameter value. -IdentifierUri Assign value for $uri. ⚠️ 2 1 Unassigned_Variable Get-AzADServicePrincipal -ObjectId $id is a null-valued parameter value. -ObjectId Assign value for $id. ⚠️ 2 1 Unassigned_Variable Update-AzADServicePrincipal -Note $note is a null-valued parameter value. -Note Assign value for $note. ⚠️ 1 1 Unassigned_Variable Update-AzADUser -UPNOrObjectId $upn is a null-valued parameter value. -UPNOrObjectId Assign value for $upn. ⚠️ 1 1 Unassigned_Variable Update-AzADUser -City $city is a null-valued parameter value. -City Assign value for $city.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Resources. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
1 task
dolauli
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qinzhouxu
pushed a commit
to qinzhouxu/azure-powershell
that referenced
this pull request
Jun 12, 2023
Azure#21760) * move application schema into commontypes.yml * support polymorphism for directoryobject * re-enable API version * add -CountVariable to list cmdlets * return when count or countvariable not provided, or consistencyLevel incorrect * return when count or countvariable not provided, or consistencyLevel incorrect * fix version for autorest/powershell dev and autorest/core * get-azadgroupmember polymorphism and countvariable (Azure#21737) * move application schema into commontypes.yml * support polymorphism for directoryobject * re-enable API version * add -CountVariable to list cmdlets * return when count or countvariable not provided, or consistencyLevel incorrect * return when count or countvariable not provided, or consistencyLevel incorrect * fix version for autorest/powershell dev and autorest/core * upgrade autorest.powershell version reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.