Skip to content

[Az.DataProtection] Added fetaure for Blob Hardening and Cross subscription restore #21789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023

Conversation

hiaga
Copy link
Member

@hiaga hiaga commented May 13, 2023

Description

Added support for Blob Hardened recovery points (VaultStore).
Added Cross Subscription Restore for AzureDisk, AzureDatabaseForPostgreSQL and AzureBlob.
Added Get-AzDataProtectionOperationStatus command for long running cmdlets Async.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 13, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.DataProtection
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Edit-AzDataProtectionPolicyRetentionRuleClientObject Edit-AzDataProtectionPolicyRetentionRuleClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Edit-AzDataProtectionPolicyRetentionRuleClientObject Edit-AzDataProtectionPolicyRetentionRuleClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Edit-AzDataProtectionPolicyTagClientObject Edit-AzDataProtectionPolicyTagClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Edit-AzDataProtectionPolicyTagClientObject Edit-AzDataProtectionPolicyTagClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Edit-AzDataProtectionPolicyTriggerClientObject Edit-AzDataProtectionPolicyTriggerClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Edit-AzDataProtectionPolicyTriggerClientObject Edit-AzDataProtectionPolicyTriggerClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionBackupInstance Get-AzDataProtectionBackupInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionBackupInstance Get-AzDataProtectionBackupInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionBackupPolicy Get-AzDataProtectionBackupPolicy Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionBackupPolicy Get-AzDataProtectionBackupPolicy changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionBackupVault Get-AzDataProtectionBackupVault Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionBackupVault Get-AzDataProtectionBackupVault changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionJob Get-AzDataProtectionJob Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionJob Get-AzDataProtectionJob changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionOperation Get-AzDataProtectionOperation Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionOperation Get-AzDataProtectionOperation changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionOperationStatus Get-AzDataProtectionOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionOperationStatus Get-AzDataProtectionOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionPolicyTemplate Get-AzDataProtectionPolicyTemplate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionPolicyTemplate Get-AzDataProtectionPolicyTemplate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionRecoveryPoint Get-AzDataProtectionRecoveryPoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionRecoveryPoint Get-AzDataProtectionRecoveryPoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataProtectionResourceGuard Get-AzDataProtectionResourceGuard Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataProtectionResourceGuard Get-AzDataProtectionResourceGuard changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Initialize-AzDataProtectionBackupInstance Initialize-AzDataProtectionBackupInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Initialize-AzDataProtectionBackupInstance Initialize-AzDataProtectionBackupInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Initialize-AzDataProtectionRestoreRequest Initialize-AzDataProtectionRestoreRequest Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Initialize-AzDataProtectionRestoreRequest Initialize-AzDataProtectionRestoreRequest changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzDataProtectionBackupConfigurationClientObject New-AzDataProtectionBackupConfigurationClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzDataProtectionBackupConfigurationClientObject New-AzDataProtectionBackupConfigurationClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzDataProtectionBackupVaultStorageSettingObject New-AzDataProtectionBackupVaultStorageSettingObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzDataProtectionBackupVaultStorageSettingObject New-AzDataProtectionBackupVaultStorageSettingObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzDataProtectionPolicyTagCriteriaClientObject New-AzDataProtectionPolicyTagCriteriaClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzDataProtectionPolicyTagCriteriaClientObject New-AzDataProtectionPolicyTagCriteriaClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzDataProtectionPolicyTriggerScheduleClientObject New-AzDataProtectionPolicyTriggerScheduleClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzDataProtectionPolicyTriggerScheduleClientObject New-AzDataProtectionPolicyTriggerScheduleClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzDataProtectionRestoreConfigurationClientObject New-AzDataProtectionRestoreConfigurationClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzDataProtectionRestoreConfigurationClientObject New-AzDataProtectionRestoreConfigurationClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzDataProtectionRetentionLifeCycleClientObject New-AzDataProtectionRetentionLifeCycleClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzDataProtectionRetentionLifeCycleClientObject New-AzDataProtectionRetentionLifeCycleClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Search-AzDataProtectionBackupInstanceInAzGraph Search-AzDataProtectionBackupInstanceInAzGraph Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Search-AzDataProtectionBackupInstanceInAzGraph Search-AzDataProtectionBackupInstanceInAzGraph changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Search-AzDataProtectionJobInAzGraph Search-AzDataProtectionJobInAzGraph Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Search-AzDataProtectionJobInAzGraph Search-AzDataProtectionJobInAzGraph changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ 2 2 Unassigned_Variable Get-AzDataProtectionBackupPolicy -SubscriptionId $sub is a null-valued parameter value. -SubscriptionId Assign value for $sub.
⚠️ 2 3 Mismatched_Parameter_Value_Type Backup-AzDataProtectionBackupInstanceAdhoc -BackupRuleOptionRuleName $policy.Property.PolicyRule[0].Name is not an expected parameter value type. -BackupRuleOptionRuleName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 2 3 Mismatched_Parameter_Value_Type Backup-AzDataProtectionBackupInstanceAdhoc -TriggerOptionRetentionTagOverride $policy.Property.PolicyRule[0].Trigger.TaggingCriterion[0].TagInfoTagName is not an expected parameter value type. -TriggerOptionRetentionTagOverride Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 2 9 Unassigned_Variable Get-AzDataProtectionJob -SubscriptionId $sub is a null-valued parameter value. -SubscriptionId Assign value for $sub.
⚠️ 2 9 Unassigned_Variable Get-AzDataProtectionJob -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName.
⚠️ 2 9 Unassigned_Variable Get-AzDataProtectionJob -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName.
⚠️ 2 1 Unassigned_Variable Edit-AzDataProtectionPolicyRetentionRuleClientObject -Policy $pol is a null-valued parameter value. -Policy Assign value for $pol.
⚠️ 1 2 Unassigned_Variable Edit-AzDataProtectionPolicyTagClientObject -Policy $pol is a null-valued parameter value. -Policy Assign value for $pol.
⚠️ 2 1 Unassigned_Variable Edit-AzDataProtectionPolicyTagClientObject -Policy $pol is a null-valued parameter value. -Policy Assign value for $pol.
⚠️ 1 2 Unassigned_Variable Edit-AzDataProtectionPolicyTriggerClientObject -Policy $pol is a null-valued parameter value. -Policy Assign value for $pol.
⚠️ 1 1 Unassigned_Variable Test-AzDataProtectionBackupInstanceReadiness -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ 1 1 Unassigned_Variable Test-AzDataProtectionBackupInstanceReadiness -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName.
⚠️ 1 1 Unassigned_Variable Test-AzDataProtectionBackupInstanceReadiness -SubscriptionId $subId is a null-valued parameter value. -SubscriptionId Assign value for $subId.
⚠️ 1 1 Unassigned_Variable Test-AzDataProtectionBackupInstanceReadiness -BackupInstance $backupInstanceClientObject.Property is a null-valued parameter value. -BackupInstance Assign value for $backupInstanceClientObject.Property.
⚠️ 1 3 Mismatched_Parameter_Value_Type Get-AzDataProtectionOperationStatus -OperationId $operationId is not an expected parameter value type. -OperationId Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 1 3 Unassigned_Variable Get-AzDataProtectionOperationStatus -Location $vault.Location is a null-valued parameter value. -Location Assign value for $vault.Location.
⚠️ 1 3 Unassigned_Variable Get-AzDataProtectionOperationStatus -SubscriptionId $subId is a null-valued parameter value. -SubscriptionId Assign value for $subId.
⚠️ 1 4 Mismatched_Parameter_Value_Type Get-AzDataProtectionOperationStatus -OperationId $operationId is not an expected parameter value type. -OperationId Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 1 4 Unassigned_Variable Get-AzDataProtectionOperationStatus -Location $vault.Location is a null-valued parameter value. -Location Assign value for $vault.Location.
⚠️ 1 4 Unassigned_Variable Get-AzDataProtectionOperationStatus -SubscriptionId $subId is a null-valued parameter value. -SubscriptionId Assign value for $subId.
⚠️ 2 1 Is_Alias where is an alias of 'Where-Object'. where {$_.Name -eq 'policyName'} Use formal name 'Where-Object' of the alias 'where'.
⚠️ 2 4 Mismatched_Parameter_Value_Type Find-AzDataProtectionRestorableTimeRange -BackupInstanceName $instance[0].BackupInstanceName is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 2 5 Unassigned_Variable Initialize-AzDataProtectionRestoreRequest -RestoreLocation $vault.Location is a null-valued parameter value. -RestoreLocation Assign value for $vault.Location.
⚠️ 2 5 Mismatched_Parameter_Value_Type Get-Date -Date $pointInTimeRange.RestorableTimeRange.EndTime is not an expected parameter value type. -Date Use correct parameter value type. Expected Type is datetime. Now the type is .(Command).
⚠️ 3 4 Mismatched_Parameter_Value_Type Find-AzDataProtectionRestorableTimeRange -BackupInstanceName $instance[0].BackupInstanceName is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 3 5 Unassigned_Variable Initialize-AzDataProtectionRestoreRequest -RestoreLocation $vault.Location is a null-valued parameter value. -RestoreLocation Assign value for $vault.Location.
⚠️ 3 5 Unassigned_Variable Initialize-AzDataProtectionRestoreRequest -BackupInstance $instances[0] is a null-valued parameter value. -BackupInstance Assign value for $instances[0].
⚠️ 4 4 Mismatched_Parameter_Value_Type Find-AzDataProtectionRestorableTimeRange -BackupInstanceName $instance[0].BackupInstanceName is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 4 5 Unassigned_Variable Initialize-AzDataProtectionRestoreRequest -RestoreLocation $vault.Location is a null-valued parameter value. -RestoreLocation Assign value for $vault.Location.
⚠️ 4 5 Unassigned_Variable Initialize-AzDataProtectionRestoreRequest -BackupInstance $instances[0] is a null-valued parameter value. -BackupInstance Assign value for $instances[0].
⚠️ 1 4 Unassigned_Variable Initialize-AzDataProtectionBackupInstance -DatasourceLocation $vault.Location is a null-valued parameter value. -DatasourceLocation Assign value for $vault.Location.
⚠️ 2 4 Unassigned_Variable Get-AzDataProtectionBackupVault -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName.
⚠️ 3 1 Is_Alias where is an alias of 'Where-Object'. where {$_.Name -eq 'policyName'} Use formal name 'Where-Object' of the alias 'where'.
⚠️ 3 8 Unassigned_Variable New-AzDataProtectionBackupInstance -SubscriptionId $sub is a null-valued parameter value. -SubscriptionId Assign value for $sub.
⚠️ 1 3 Mismatched_Parameter_Value_Type New-AzDataProtectionBackupVault -StorageSetting $storagesetting is not an expected parameter value type. -StorageSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api202301.IStorageSetting. Now the type is psobject.(Command).
⚠️ 2 3 Mismatched_Parameter_Value_Type New-AzDataProtectionBackupVault -StorageSetting $storagesetting is not an expected parameter value type. -StorageSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api202301.IStorageSetting. Now the type is psobject.(Command).
⚠️ 1 1 Unassigned_Variable Resume-AzDataProtectionBackupInstanceProtection -BackupInstanceName $backupInstance.BackupInstanceName is a null-valued parameter value. -BackupInstanceName Assign value for $backupInstance.BackupInstanceName.
⚠️ 1 1 Unassigned_Variable Set-AzDataProtectionMSIPermission -BackupInstance $instance is a null-valued parameter value. -BackupInstance Assign value for $instance.
⚠️ 2 1 Unassigned_Variable Set-AzDataProtectionMSIPermission -BackupInstance $instance is a null-valued parameter value. -BackupInstance Assign value for $instance.
⚠️ 3 1 Unassigned_Variable Set-AzDataProtectionMSIPermission -BackupInstance $instance is a null-valued parameter value. -BackupInstance Assign value for $instance.
⚠️ 4 1 Unassigned_Variable Set-AzDataProtectionMSIPermission -BackupInstance $backupInstance is a null-valued parameter value. -BackupInstance Assign value for $backupInstance.
⚠️ 1 4 Mismatched_Parameter_Value_Type Start-AzDataProtectionBackupInstanceRestore -BackupInstanceName $instance.BackupInstanceName is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 2 5 Mismatched_Parameter_Value_Type Initialize-AzDataProtectionRestoreRequest -RecoveryPoint $rp[0].Property.RecoveryPointId is not an expected parameter value type. -RecoveryPoint Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 2 6 Mismatched_Parameter_Value_Type Start-AzDataProtectionBackupInstanceRestore -BackupInstanceName $instance.BackupInstanceName is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 3 5 Mismatched_Parameter_Value_Type Initialize-AzDataProtectionRestoreRequest -RecoveryPoint $rp[0].Property.RecoveryPointId is not an expected parameter value type. -RecoveryPoint Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 3 6 Mismatched_Parameter_Value_Type Start-AzDataProtectionBackupInstanceRestore -BackupInstanceName $instance.BackupInstanceName is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 4 1 Is_Alias Where is an alias of 'Where-Object'. Where { $_.Name -match 'aks-cluster-name' } Use formal name 'Where-Object' of the alias 'Where'.
⚠️ 4 5 Unassigned_Variable Initialize-AzDataProtectionRestoreRequest -RecoveryPoint $rps[0].Property.RecoveryPointId is a null-valued parameter value. -RecoveryPoint Assign value for $rps[0].Property.RecoveryPointId.
⚠️ 4 5 Mismatched_Parameter_Value_Type Initialize-AzDataProtectionRestoreRequest -RestoreConfiguration $aksRestoreCriteria is not an expected parameter value type. -RestoreConfiguration Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api202301.KubernetesClusterRestoreCriteria. Now the type is psobject.(Command).
⚠️ 4 8 Mismatched_Parameter_Value_Type Test-AzDataProtectionBackupInstanceRestore -Name $instance.BackupInstanceName is not an expected parameter value type. -Name Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 4 9 Mismatched_Parameter_Value_Type Start-AzDataProtectionBackupInstanceRestore -BackupInstanceName $instance.BackupInstanceName is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 1 1 Unassigned_Variable Stop-AzDataProtectionBackupInstanceProtection -BackupInstanceName $backupInstance.BackupInstanceName is a null-valued parameter value. -BackupInstanceName Assign value for $backupInstance.BackupInstanceName.
⚠️ 1 1 Unassigned_Variable Suspend-AzDataProtectionBackupInstanceBackup -BackupInstanceName $backupInstance.BackupInstanceName is a null-valued parameter value. -BackupInstanceName Assign value for $backupInstance.BackupInstanceName.
⚠️ 1 2 Mismatched_Parameter_Value_Type Find-AzDataProtectionRestorableTimeRange -BackupInstanceName $instances[0].BackupInstanceName is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command).
⚠️ 1 4 Mismatched_Parameter_Value_Type Get-Date -Date $pointInTimeRange.RestorableTimeRange.EndTime is not an expected parameter value type. -Date Use correct parameter value type. Expected Type is datetime. Now the type is .(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.DataProtection. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 65.12 % 66.67% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 65.12% 66.67% Test coverage cannot be lower than the number of the last release.

Added Cross Subscription Restore for AzureDisk, AzureDatabaseForPostgreSQL and AzureBlob.
Added Get-AzDataProtectionOperationStatus command for long running cmdlets Async.
msJinLei
msJinLei previously approved these changes May 15, 2023
@msJinLei msJinLei added Breaking Change Release This PR contains breaking change DataProtection and removed needs-review labels May 15, 2023
@msJinLei msJinLei dismissed their stale review May 15, 2023 05:00

Unnotified breaking change

@msJinLei
Copy link
Contributor

@hiaga

You should firstly add breaking change notification to the existing codes 2 sprints ahead to notify customers and then submit the breaking changes before the next major release.

please refer to the wiki for more details
https://eng.ms/docs/cloud-ai-platform/azure-core/azure-management-and-platforms/control-plane-bburns/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/teams_docs/azps_docs/breakingchange_release_process

@msJinLei
Copy link
Contributor

IBackupDatasourceParameters is the base class of KubernetesClusterBackupDatasourceParameters

@msJinLei msJinLei merged commit 53b5bb3 into Azure:generation May 15, 2023
qinzhouxu pushed a commit to qinzhouxu/azure-powershell that referenced this pull request Jun 12, 2023
…21789)

Added Cross Subscription Restore for AzureDisk, AzureDatabaseForPostgreSQL and AzureBlob.
Added Get-AzDataProtectionOperationStatus command for long running cmdlets Async.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change DataProtection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants