Skip to content

Fix issue #674, #1221, #270 #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2016
Merged

Fix issue #674, #1221, #270 #2184

merged 3 commits into from
May 5, 2016

Conversation

TianoMS
Copy link

@TianoMS TianoMS commented Apr 30, 2016

No description provided.

@azurecla
Copy link

Hi @TianoMS, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (tiano). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@TianoMS
Copy link
Author

TianoMS commented Apr 30, 2016

@@ -73,7 +73,7 @@ internal static PSObject ToPsObject(this JToken jtoken, string objectType = null
foreach (var property in jobject.Properties())
{
psObject.Properties.Add(new PSNoteProperty(
name: JTokenExtensions.ConvertToPascalCase(propertyName: property.Name),
name: property.Name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a test for this? Feel free to edit one of our existing resources tests to add a check for this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this.

@TianoMS
Copy link
Author

TianoMS commented May 3, 2016

@hovsepm
Copy link
Contributor

hovsepm commented May 3, 2016

LGTM

@hovsepm hovsepm merged commit 7e5a491 into Azure:dev May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants