Skip to content

Adding cmdlets + tests for ServerManagement #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 9, 2016
Merged

Adding cmdlets + tests for ServerManagement #2193

merged 15 commits into from
May 9, 2016

Conversation

fearthecowboy
Copy link
Contributor

No description provided.

@azurecla
Copy link

azurecla commented May 2, 2016

Hi @fearthecowboy, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (garretts). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci
Copy link

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor

hovsepm commented May 5, 2016

@azuresdkci add to whitelist

@fearthecowboy
Copy link
Contributor Author

And it now magically passed CI!

YAY!



[Fact]
public void TestGateway()
Copy link
Contributor

@hovsepm hovsepm May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fearthecowboy please add default constructor to this class and add following line to it https://github.com/Azure/azure-powershell/blob/dev/src/ResourceManager/Profile/Commands.Profile.Test/TenantCmdletTests.cs#L34
otherwise your test output will not be visible during VS execution and CI run.

Copy link
Contributor Author

@fearthecowboy fearthecowboy May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing...

[Wow... none of that interceptor stuff was in the repo when I cloned it...]

@hovsepm
Copy link
Contributor

hovsepm commented May 6, 2016

sing job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/421/
@fearthecowboy , Once this job succeeds please check Artifacts folder and verify that MSI and Packages will contain your module.

@fearthecowboy
Copy link
Contributor Author

@hovsepm The MSI isn't right; I was unaware of the settings to add the module to the MSI.

I think I got the stuff added in that last commit.

@hovsepm
Copy link
Contributor

hovsepm commented May 6, 2016

@fearthecowboy you definitely do not need the nuget config. It points to:

  1. nuget.org feed that is already included in the build
  2. your local nuget feed which does not exist on the CI Jenkins builders at all.

@hovsepm
Copy link
Contributor

hovsepm commented May 6, 2016

@fearthecowboy at least remove package sources from the nuget.config

@fearthecowboy
Copy link
Contributor Author

@hovsepm Yeah, I meant to remove the sources from nuget.config.

lol.. I actually did that but accidentally copied back the original (with sources) before commiting. sigh... never do anything in a rush on Friday afternoons.

@fearthecowboy
Copy link
Contributor Author

@hovsepm The job http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/422 does indeed contain the stuff in the psget package and the msi package. (Installed, and verified that it works :) )

ProcessorArchitecture = 'None'

# Modules that must be imported into the global environment prior to importing this module
RequiredModules = @( @{ ModuleName = 'AzureRM.Profile'; ModuleVersion = '1.0.7'})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fearthecowboy and the last comment - this should be version 1.0.8

@hovsepm hovsepm merged commit e095bd4 into Azure:dev May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants