-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding cmdlets + tests for ServerManagement #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @fearthecowboy, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
Can one of the admins verify this patch? |
@azuresdkci add to whitelist |
And it now magically passed CI! YAY! |
|
||
|
||
[Fact] | ||
public void TestGateway() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fearthecowboy please add default constructor to this class and add following line to it https://github.com/Azure/azure-powershell/blob/dev/src/ResourceManager/Profile/Commands.Profile.Test/TenantCmdletTests.cs#L34
otherwise your test output will not be visible during VS execution and CI run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing...
[Wow... none of that interceptor stuff was in the repo when I cloned it...]
sing job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/421/ |
@hovsepm The MSI isn't right; I was unaware of the settings to add the module to the MSI. I think I got the stuff added in that last commit. |
@fearthecowboy you definitely do not need the nuget config. It points to:
|
@fearthecowboy at least remove package sources from the nuget.config |
@hovsepm Yeah, I meant to remove the sources from nuget.config. lol.. I actually did that but accidentally copied back the original (with sources) before commiting. sigh... never do anything in a rush on Friday afternoons. |
@hovsepm The job http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/422 does indeed contain the stuff in the psget package and the msi package. (Installed, and verified that it works :) ) |
ProcessorArchitecture = 'None' | ||
|
||
# Modules that must be imported into the global environment prior to importing this module | ||
RequiredModules = @( @{ ModuleName = 'AzureRM.Profile'; ModuleVersion = '1.0.7'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fearthecowboy and the last comment - this should be version 1.0.8
No description provided.