-
Notifications
You must be signed in to change notification settings - Fork 4k
New cmdlets for managed database move and copy operations #22012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Compute
️✔️Az.EventHub
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.Sql
️✔️Az.Storage
|
…hich will be more useful forr customers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be useful to double check the strings (help files/param desc) with the PM
src/Sql/Sql/ManagedDatabase/Cmdlet/MoveCopy/GetAzureSqlManagedDatabaseCopyOperation.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedDatabase/Cmdlet/MoveCopy/MoveCopyAzureSqlManagedDatabaseBase.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedDatabase/Services/AzureSqlManagedDatabaseCommunicator.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedDatabase/Services/AzureSqlManagedDatabaseAdapter.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedDatabase/Cmdlet/MoveCopy/StopAzureSqlManagedDatabaseMove.cs
Show resolved
Hide resolved
src/Sql/Sql/ManagedDatabase/Cmdlet/MoveCopy/StopAzureSqlManagedDatabaseCopy.cs
Show resolved
Hide resolved
src/Sql/Sql/ManagedDatabase/Cmdlet/MoveCopy/GetMoveCopyAzureSqlManagedDatabaseOperationsBase.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedDatabase/Cmdlet/MoveCopy/GetMoveCopyAzureSqlManagedDatabaseOperationsBase.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedDatabase/Cmdlet/MoveCopy/GetMoveCopyAzureSqlManagedDatabaseOperationsBase.cs
Outdated
Show resolved
Hide resolved
@milanbrkic-ms Can you please check in all the updated files under Sql.Sdk when generating with autorest. Otherwise, it may have potential issue. If you prefer me to do it, please let me know. Thanks! |
@vidai-msft but I have already checked in all files that I changed, and that is one swagger for ManagedDatabaseMoveOperation |
That is the reason why we need to make a single commit id. Partial update may have potential issues and make the models/operations not consistent. Let me raise a PR to merge all the updates for SDK that are not related to your swagger. |
Raised #22087 to upload all files for Sql.Sdk |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.