Use backoff delay for New-AzureRmResourceGroupDeployment query calls #2205
Conversation
|
Hi @TianoMS, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
|
||
| do | ||
| { | ||
| TestMockSupport.Delay(stepedDelay.GetNextDelay()); |
There was a problem hiding this comment.
Why can't we just do:
int counter = 0;
do
{
counter = counter + 5000 > 60000 ? 60000 : counter + 5000;
TestMockSupport.Delay(counter);
...
}
There was a problem hiding this comment.
Per our sync up, will change it to the simple way as we don't see future reuse of this.
| { | ||
| this.backoffStep = backoffStep; | ||
| this.maxDelay = maxDelay; | ||
|
|
There was a problem hiding this comment.
Talked with Vivek yesterday. We don't see future reuse of this delay pattern, so I changed it to the simple way to get incremental stepped delay. I committed another change and this class was removed.
| [Parameter(Mandatory = false, HelpMessage = "A hash table which represents resource plan properties.")] | ||
| [ValidateNotNullOrEmpty] | ||
| public Hashtable PlanObject { get; set; } | ||
| public Hashtable Plan { get; set; } |
There was a problem hiding this comment.
Here we should add a help which suggest old parameter will still work
So help says you can use Plan or PlanObject parameter
This PR fixes two issues:
#1808,
#358