Add parameter DomainNameLabelScope for PublicIpAddress #22052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Batch
️✔️Az.CognitiveServices
️✔️Az.Compute
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 36.67 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 36.67% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 36.67% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 36.67% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.DataLakeStore
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Dns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 42.31 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 42.31% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 42.31% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 42.31% Test coverage for the module cannot be lower than 50%.
️✔️Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ 1 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 1 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 1 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 1 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -ReverseFqdn $customFqdn is a null-valued parameter value. -ReverseFqdn Assign value for $customFqdn. ⚠️ 3 2 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 3 2 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 3 2 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 3 2 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -PublicIpPrefix $publicIpPrefix is a null-valued parameter value. -PublicIpPrefix Assign value for $publicIpPrefix. ⚠️ 5 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 5 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 5 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 5 1 Unassigned_Variable New-AzPublicIpAddress -PublicIpPrefix $publicIpPrefix is a null-valued parameter value. -PublicIpPrefix Assign value for $publicIpPrefix. ⚠️ 6 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 6 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 6 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $domainNameLabel is a null-valued parameter value. -DomainNameLabel Assign value for $domainNameLabel. ⚠️ 6 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabelScope $hasedReusePolicy is a null-valued parameter value. -DomainNameLabelScope Assign value for $hasedReusePolicy. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ 1 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 1 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 1 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 1 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 2 1 Unassigned_Variable New-AzPublicIpAddress -ReverseFqdn $customFqdn is a null-valued parameter value. -ReverseFqdn Assign value for $customFqdn. ⚠️ 3 2 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 3 2 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 3 2 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 3 2 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 4 1 Unassigned_Variable New-AzPublicIpAddress -PublicIpPrefix $publicIpPrefix is a null-valued parameter value. -PublicIpPrefix Assign value for $publicIpPrefix. ⚠️ 5 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 5 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 5 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 5 1 Unassigned_Variable New-AzPublicIpAddress -PublicIpPrefix $publicIpPrefix is a null-valued parameter value. -PublicIpPrefix Assign value for $publicIpPrefix. ⚠️ 6 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 6 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 6 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $domainNameLabel is a null-valued parameter value. -DomainNameLabel Assign value for $domainNameLabel. ⚠️ 6 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -Name $publicIpName is a null-valued parameter value. -Name Assign value for $publicIpName. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -ResourceGroupName $rgName is a null-valued parameter value. -ResourceGroupName Assign value for $rgName. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabel $dnsPrefix is a null-valued parameter value. -DomainNameLabel Assign value for $dnsPrefix. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -DomainNameLabelScope $hasedReusePolicy is a null-valued parameter value. -DomainNameLabelScope Assign value for $hasedReusePolicy. ⚠️ 7 1 Unassigned_Variable New-AzPublicIpAddress -Location $location is a null-valued parameter value. -Location Assign value for $location. ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 25.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 25.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 25.00% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 25.00% Test coverage for the module cannot be lower than 50%.
⚠️ Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 59.93 % 61.56% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 59.93% 61.56% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 59.93% 61.56% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 59.93% 61.56% Test coverage cannot be lower than the number of the last release.
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 42.20 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 42.20% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 42.20% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 42.20% Test coverage for the module cannot be lower than 50%.
|
@tinama0302 Can you please help resolve the Build error from the CI? In addition, I noticed you have added a new test case but I did not see the recorded JSON file. Can you please upload it as well? |
vidai-msft
reviewed
Jun 16, 2023
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vidai-msft
approved these changes
Jun 16, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR is to add an optional parameter(DomainNameLabelScope) for public ip address, so that customer can specify the hashed reuse policy when create DNS record.
Issue for this PR: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1347
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.