Skip to content

fix issue with installmodule script #22055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix issue with installmodule script #22055

merged 1 commit into from
Jun 15, 2023

Conversation

Nickcandy
Copy link
Contributor

@Nickcandy Nickcandy commented Jun 13, 2023

Description

fix issue[#21867]
In azps docker file, installation for the latest version az has a different scope from the old version. This pr would add a new parameter scope for InstallModule.ps1 and change all the docker file to AllUser scope

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 13, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@Nickcandy Nickcandy linked an issue Jun 13, 2023 that may be closed by this pull request
@Nickcandy Nickcandy requested a review from isra-fel June 13, 2023 06:14
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Nickcandy please briefly summarize your PR in the description

@isra-fel isra-fel requested a review from BethanyZhou June 13, 2023 06:40
@Nickcandy
Copy link
Contributor Author

@BethanyZhou Hi Beisi, the docker file cannot be tested in the docker pipeline for now cause it requires updates in our blob. Please help me double-check it.

@BethanyZhou
Copy link
Contributor

@Nickcandy Have you verified the new scripts in ADO? If yes, please paste the test link here.

@BethanyZhou
Copy link
Contributor

Tested on local. Looks good to me

@Nickcandy Nickcandy merged commit a2eb28f into main Jun 15, 2023
@Nickcandy Nickcandy deleted the lnx/installModule branch June 16, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use Docker container with AzDo pipeline task
3 participants