Skip to content

Update New-AzSentinelAlertRule.md #22123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

PoonamYadavMS
Copy link
Contributor

Need to update - From Creates or updates the alert rule to Creates the alert rule

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Need to update - From Creates or updates the alert rule to Creates   the alert rule
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 21, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SecurityInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@PoonamYadavMS
Copy link
Contributor Author

#sign-off

1 similar comment
@PoonamYadavMS
Copy link
Contributor Author

#sign-off

@PoonamYadavMS PoonamYadavMS requested a review from VeryEarly June 21, 2023 12:07
@PoonamYadavMS PoonamYadavMS self-assigned this Jun 21, 2023
@PoonamYadavMS
Copy link
Contributor Author

#sign-off

@vidai-msft vidai-msft merged commit c97dfcb into Azure:main Jun 21, 2023
@PoonamYadavMS
Copy link
Contributor Author

PoonamYadavMS commented Jun 21, 2023 via email

@vidai-msft
Copy link
Contributor

Hi Vincent, Changes are still not reflected on New-AzSentinelAlertRule (Az.SecurityInsights) | Microsoft Learn https://learn.microsoft.com/en-us/powershell/module/az.securityinsights/new-azsentinelalertrule?view=azps-10.0.0&viewFallbackFrom=azps-9.4.0 [image: image.png] I have removed "updates" but it's still showing on public documents.

On Wed, Jun 21, 2023 at 4:04 PM Vincent Dai @.> wrote: Merged #22123 <#22123> into main. — Reply to this email directly, view it on GitHub <#22123 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AODU2DXHZIEYNKVLQXYC3C3XMMEONANCNFSM6AAAAAAZOTGVCA . You are receiving this because you were assigned.Message ID: @.>

@PoonamYadavMS We have not published the changes to the public. The next release date is July 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants