Skip to content

Save branch #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2015
Merged

Save branch #229

merged 4 commits into from
Mar 6, 2015

Conversation

NaveenGoli
Copy link
Contributor

No description provided.

@azurecla
Copy link

azurecla commented Mar 4, 2015

Hi @NaveenGoli, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (ngoli). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@NaveenGoli NaveenGoli force-pushed the save-branch branch 2 times, most recently from aaa345f to 9fd4b5c Compare March 5, 2015 07:52
markcowl
markcowl reviewed Mar 5, 2015
View reviewed changes
src/Common/Commands.ScenarioTests.Common/Commands.ScenarioTests.Common.csproj
@@ -129,6 +129,10 @@
<None Include="packages.config" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\ResourceManager\Websites\Commands.Websites\Commands.Websites.csproj">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary

@markcowl
Copy link
Member

markcowl commented Mar 5, 2015

@NaveenGoli Reviewed, please respond to feedback

@NaveenGoli NaveenGoli force-pushed the save-branch branch 4 times, most recently from a56f8b0 to 425a0a2 Compare March 6, 2015 03:22
@NaveenGoli
removed hardcoding in the tests; removed unnecessary references, adde…
b007564 
…d updated json files

Added test cases to the targets file

changed the dll version for microsoft.azure.common to 14 to make the failing test pass
@ogail
Copy link
Contributor

ogail commented Mar 6, 2015

test this please

@NaveenGoli
Copy link
Contributor Author

Seems like this passed, what do you want me to test?

Sent from my Windows Phone

From: Abdelrahman Elogeelmailto:[email protected]
Sent: ‎3/‎5/‎2015 10:37 PM
To: Azure/azure-powershellmailto:[email protected]
Cc: Naveen Golimailto:[email protected]
Subject: Re: [azure-powershell] Save branch (#229)

test this please

Reply to this email directly or view it on GitHub:
#229 (comment)

@azurecompliance4
Copy link

That's just an instruction to the Jenkins server to run the job.

From: Naveen Golimailto:[email protected]
Sent: ý3/ý6/ý2015 12:49 AM
To: Azure/azure-powershellmailto:[email protected]
Subject: Re: [azure-powershell] Save branch (#229)

Seems like this passed, what do you want me to test?

Sent from my Windows Phone

From: Abdelrahman Elogeelmailto:[email protected]
Sent: ý3/ý5/ý2015 10:37 PM
To: Azure/azure-powershellmailto:[email protected]
Cc: Naveen Golimailto:[email protected]
Subject: Re: [azure-powershell] Save branch (#229)

test this please

Reply to this email directly or view it on GitHub:
#229 (comment)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/229#issuecomment-77525539.

ogail added a commit that referenced this pull request Mar 6, 2015
@ogail
Merge pull request #229 from NaveenGoli/save-branch
a1a8503 
Save branch
@ogail ogail merged commit a1a8503 into Azure:dev Mar 6, 2015
huangpf added a commit to AzureRT/azure-powershell that referenced this pull request Dec 6, 2015
@huangpf
Merge pull request Azure#229 from Azure/dev
a9a1eda 
.
markcowl pushed a commit that referenced this pull request Apr 28, 2016
@pragrawa
Merge pull request #229 from MabOneSdk/pragrawa-dev1
db51176 
moving protection tracking logid to common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NaveenGoli @azurecla @markcowl @ogail @azurecompliance4