[CustomLocation] Update custom location api version #23598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzCustomLocation | Get-AzCustomLocation Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzCustomLocation | Get-AzCustomLocation changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzCustomLocationEnabledResourceType | Get-AzCustomLocationEnabledResourceType Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzCustomLocationEnabledResourceType | Get-AzCustomLocationEnabledResourceType changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzCustomLocationResourceSyncRule | Get-AzCustomLocationResourceSyncRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzCustomLocationResourceSyncRule | Get-AzCustomLocationResourceSyncRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzCustomLocationMatchExpressionsObject | New-AzCustomLocationMatchExpressionsObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.CustomLocation. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
|
|
|
Need service team feedback |
dolauli
requested changes
Dec 8, 2023
| use-extension: | ||
| "@autorest/powershell": "3.x" | ||
| "@autorest/powershell": "4.x" |
There was a problem hiding this comment.
Use-extension is not needed here, since the default extension is 4.x
|
|
||
| module-version: 0.1.0 | ||
| title: CustomLocation | ||
| subject-prefix: $(service-name) | ||
|
|
||
| identity-correction-for-post: true | ||
| resourcegroup-append: true |
There was a problem hiding this comment.
Please remove line 44 and line 45, since they are true by default in v4.
|
|
||
| module-version: 0.1.0 | ||
| title: CustomLocation | ||
| subject-prefix: $(service-name) | ||
|
|
||
| identity-correction-for-post: true | ||
| resourcegroup-append: true | ||
| nested-object-to-string: true | ||
| auto-switch-view: false |
There was a problem hiding this comment.
Any special reason we add line 46, if not, please remove it.
| @@ -1,7 +1,6 @@ | |||
|
|
|||
There was a problem hiding this comment.
What are these two custom cmdlets for? It seems there are not any custom logic
There was a problem hiding this comment.
ClusterExtensionId, HostResourceId, Namespace
The service team believes that these three parameters should be mandatory.
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
dolauli
approved these changes
Dec 12, 2023
1 task
This was referenced Mar 17, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/extendedlocation/resource-manager/Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json
Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1400
ChangeLog
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.