Skip to content

Adds new ARM cmdlets #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 7, 2015
Merged

Adds new ARM cmdlets #238

merged 7 commits into from
Mar 7, 2015

Conversation

chadiel
Copy link
Contributor

@chadiel chadiel commented Mar 6, 2015

No description provided.

chadiel added 2 commits March 5, 2015 16:24
- Register-AzureProvider
- Unregister-AzureProvider
- Get-AzureProvider
- Register-AzureProviderFeature
- Get-AzureProviderFeature
- Move-AzureResource
@azurecla
Copy link

azurecla commented Mar 6, 2015

Hi @chadiel, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (chadiel). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@markcowl
Copy link
Member

markcowl commented Mar 6, 2015

@chadiel Shadi, it looks like what's happening is that a new API version in the resources client is not matching the APIVersion in the recorded mocks for the providers list call used by Get-AzureLocation. It is OK to do a search/replace on the mocks to change the API version, assuming the contracts haven't changed.

@chadiel
Copy link
Contributor Author

chadiel commented Mar 6, 2015

I actually figured out what the problem – the API version didn’t change, instead there seems to be a bit of a behavior change where the .NET SDK doesn’t append the extra ‘&’ to the request URI (seems like it was a bug fix somewhere.) Anyway, it seems like the MockHttpServer you guys use does a simple match against the URI. This has 2 problems: 1) The mock server does a simple string lookup and is not intelligent enough to handle cosmetic changes to the query such as this one and more importantly 2) https traffic has it’s URIs Base64 encoded which means that you look for the encoded version of the strings – so it’s not as simple as just doing a find and replace.

I’m going to only update the .NET SDK for the ARM library since I can (for the most part) re-record/patch those test cases to make them work but I cannot do it for all other recorded session. Will update the PR shortly.

markcowl added a commit that referenced this pull request Mar 7, 2015
@markcowl markcowl merged commit 14fee64 into Azure:release-0.8.15 Mar 7, 2015
huangpf added a commit to AzureRT/azure-powershell that referenced this pull request Dec 10, 2015
markcowl pushed a commit that referenced this pull request Apr 28, 2016
RI from release to dev1-sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants