Handle invalid locations for Get-AzureRmResourceProvider. #2380
Conversation
| @@ -89,5 +91,38 @@ public override void ExecuteCmdlet() | |||
| this.WriteObject(providers, enumerateCollection: true); | |||
| } | |||
| } | |||
|
|
|||
| private PSResourceProvider[] ListPSResourceProviders() | |||
There was a problem hiding this comment.
I assumed PS stands for PowerShell, its good to call it ListPowerShellResourceProviders
There was a problem hiding this comment.
The PowerShell practice is in preference to PS abbreviation. For example, the base class PSObject, PSCustomObject. Here I think we can follow the practice.
There was a problem hiding this comment.
The PowerShell practice is in preference to PS abbreviation. For example, the base class PSObject, PSCustomObject. Here I think we can follow the practice.
There was a problem hiding this comment.
Not related to to PR, but I believe this was checked in few weeks ago - in correct summary Refers to: src/ResourceManager/Resources/Commands.ResourceManager/Cmdlets/Implementation/Providers/GetAzureProviderCmdlet.cs:47 in 0c03564. [](commit_id = 0c03564, deletion_comment = False) |
| foreach (var provider in providers) | ||
| { | ||
| provider.ResourceTypes = provider.ResourceTypes | ||
| .Where(type => !type.Locations.Any() || type.Locations.Any(loc => loc.EqualsAsLocation(this.Location))) |
There was a problem hiding this comment.
check type.Locations not null before type.Locations.Any()
Fix issue #2218.