Skip to content

Key Vault: Ensure cached tokens are used during authentication #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2016

Conversation

seanbamsft
Copy link
Contributor

In non-interactive environments we cannot show an auth dialog, so we need to ensure that silent auth is being used (fixes #2105). In addition, in certain configurations users have seen the KV cmdlets report that "credentials have not been set up or have expired". This is caused by not using the serialized cache from AzureContext.TokenCache. The changes in this PR are based off of the code in AuthenticationFactory, but due to our use of a Hyak-based client, we cannot use the existing functions. Once we adopt autorest, we can remove this code and use the shared implementation.

@azurecla
Copy link

azurecla commented Jun 3, 2016

Hi @seanbamsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (seanba). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm hovsepm merged commit fd6ca08 into Azure:dev Jun 7, 2016
@seanbamsft seanbamsft deleted the authfix branch September 14, 2016 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants