Skip to content

ADL Updates: Defaults and Convenience #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2016
Merged

ADL Updates: Defaults and Convenience #2435

merged 7 commits into from
Jun 16, 2016

Conversation

begoldsm
Copy link
Contributor

This PR does the following:

  1. Fixes default thread counts for file and folder upload
  2. Updates Get-AzureRMDataLakeAnalyticsDataSource "list" operation to return all data sources as a new common data source object. This also indicates which data source is the default.
  3. Update documentation and comments to reflect the above two changes.
  4. Update tests

begoldsm added 4 commits June 9, 2016 15:15
Default threading values are now set to 5 and 10 for concurrent files
and threads per file, respectively.
Also, improved the experience for listing data sources to list all data
sources and tag them as default if they are the default. Retrieving a
specific data source continues to behave the same as it always has.
@markcowl
Copy link
Member

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/898/

LGTM once the build passes, though I would really like to know where the need for the new client comes from.

@begoldsm
Copy link
Contributor Author

begoldsm commented Jun 16, 2016

@markcowl I agree, it is quite confusing to me as well. I suspect it will go away once the "tags" stuff is moved into a more common location (maybe)?

Also, @markcowl on demand run passed, can we get this merged?

@markcowl markcowl merged commit 516a1f0 into Azure:dev Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants