Skip to content

LogicApp/IntegrationAccount PSCmdlets #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 91 commits into from
Closed

LogicApp/IntegrationAccount PSCmdlets #2495

wants to merge 91 commits into from

Conversation

pankajsn
Copy link
Contributor

This includes the PS cmdlets for the LogicApp/IntegrationAccounts. Currently LogicApp SDK (for Integration Account related updates) in review and the nuget package is yet not published in Nuget Gallery. We want to start this pull request to fix review comments in parallel. Once SDK pull request is complete, we need to publish the nuget package and merge this request.

hchungmsft and others added 30 commits March 15, 2016 10:44
@hchungmsft
new helpfile
07c8a16
@hchungmsft
initial implementation
e53e3cd
@hchungmsft
Merge branch 'dev' of https://github.com/Azure/azure-powershell into …
c6bf469 
…helpfile
@hchungmsft
add test outlines
fb1c57e
@hchungmsft
renames
085bc06
@hchungmsft
update names
ed9161b
@hchungmsft
implement tests, rename to LTR
d38cd0b
@hchungmsft
add new nuget
a8afbb5
@hchungmsft
merge
78cb4ff
@hchungmsft
merge
14d1adc
@hchungmsft
add private flag
fd44bd3
@hchungmsft
add session records
6143072
@hchungmsft
add LTR restore test
404c79e
@hchungmsft
resolve conflicts
8259950
@hchungmsft
undo downgrade
7829ccb
@hchungmsft
use string for state to match API
0398f0f
@matthew-rollitt
Made it so file path isn't needed when only activate is on
43be860
@matthew-rollitt
added blank line
beb388e
@dihan0604
Expose correct error message to customer
3bdd662
@dihan0604
Error handling : return correct error message to customers
8e3fc24
@dihan0604
change aligning
01fc38d
@matthew-rollitt
Covering the case where you can activate an application package with …
67c89b2 
…no filePath needed
@dihan0604
move changes to network cmdlets
a1fa5dd
@dihan0604
update function name
b975018
@dihan0604
update network dll version
0038f85
@dihan0604
add Error class
4f4ec77
@hchungmsft
add helpfile, bump sdk versions
104c86f
@hchungmsft
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
dc1744e
@hchungmsft
remove reference to unimplemented feature
7559894
@dihan0604
Update all network cmdlets to handle cloud exception
e494a47
markcowl added 3 commits June 22, 2016 16:05
@markcowl
Update AzurePowershell.Test.targets
5b5a9ac
@markcowl
Merge pull request #2403 from hchungmsft/dev
1fcc992 
Cmdlets for Azure RM SQL Long Term Retention Backup/Restore
@markcowl
Merge pull request #2475 from DamirAinullin/dev
36190d4 
fixes of obvious code mistakes
@markcowl
Copy link
Member

@pankajsn Looks like you need to publish your management package to nuget

markcowl and others added 4 commits June 23, 2016 09:54
@markcowl
Merge pull request #2496 from Azure/checkin-test
69b4196 
Add missing test projects to checkin test library
@markcowl
Merge pull request #2428 from dihan0604/dev
a343619 
Error Handling: Expose error message to customers
@vivsriaus
Add null check in AzureRM.Resources.ps1
0873302
Merge pull request #2510 from vivsriaus/AddIdentity
99bbde8 
Add null check in AzureRM.Resources.ps1
@pankajsn
Copy link
Contributor Author

Is there any specific steps we need to follow to publish the management package ? (The pull request for the same is completed now)

From: Mark Cowlishaw [mailto:[email protected]]
Sent: Thursday, June 23, 2016 9:54 AM
To: Azure/azure-powershell [email protected]
Cc: Pankaj Singh Negi [email protected]; Mention [email protected]
Subject: Re: [Azure/azure-powershell] LogicApp/IntegrationAccount PSCmdlets (#2495)

@pankajsnhttps://github.com/pankajsn Looks like you need to publish your management package to nuget

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/2495#issuecomment-228112694, or mute the threadhttps://github.com/notifications/unsubscribe/APZfc5K8uwViwYELS9ba8drHQZBaAlQaks5qOroSgaJpZM4I8B5c.

Matt-Westphal and others added 14 commits June 24, 2016 12:21
@Matt-Westphal
update package for UsageAggregates
f3bacdb 
update package for UsageAggregates
Merge pull request #2513 from Matt-Westphal/dev
52495f2 
update package version for UsageAggregates
Merge pull request #2490 from matthew-rollitt/feature/app-pack-hotfix
1e93de2 
Feature/app pack hotfix
Merge pull request #2493 from MSSedusch/dev
a197579 
fix VM size information
@solankisamir
Remove restriction on Regions for MoonCake Environment (#2507)
19063d0 
Remove Location restrictions while creating a New ApiManagement Service
@johnmic
Update documentation for *-AzureRmNetworkInterface cmdlets (#2506)
a1c152f
@pankajsn
LogicApp/IntegrationAccount cmdlets with updated LogicApp/Integration…
a4de0cc 
…Account SDK
@pankajsn
Merge branch 'dev_CompositeClient' of https://github.com/pankajsn/azu…
86123a8 
…re-powershell into dev_CompositeClient

Conflicts:
	src/ResourceManager/LogicApp/Commands.LogicApp.Test/Commands.LogicApp.Test.csproj
@pankajsn
Merge branch 'dev_CompositeClient' of https://github.com/pankajsn/azu…
2e32d1f 
…re-powershell into dev_CompositeClient

Conflicts:
	src/ResourceManager/LogicApp/Commands.LogicApp.Test/Commands.LogicApp.Test.csproj
@pankajsn
Merge branch 'dev_CompositeClient' of https://github.com/pankajsn/azu…
97a5470 
…re-powershell into dev_CompositeClient
@pankajsn
Merge branch 'dev_CompositeClient' into LocalMergeBranch
d45aae7 
Conflicts:
	ChangeLog.md
@pankajsn
Fixed session record file setting
b3ab6d1
@pankajsn
Merge branch 'dev_CompositeClient' of https://github.com/pankajsn/azu…
bb31e22 
…re-powershell into dev_CompositeClient
@pankajsn
Fixed the dll version conflict (Microsoft.Rest.ClientRuntime.Azure)
2ad995b
@markcowl
Copy link
Member

@pankajsn It looks like there are some new CredScan issues in your help document - you can either change them, or add this file to exceptions here: https://github.com/Azure/azure-powershell/blob/dev/tools/GlobalFilters.xml after PR #2524 is merged

@markcowl
Copy link
Member

@pankajsn This has way too many changes outside your folder.

First: Please squash the commits 91 commits is too many for a cmdlet update
Second: It looks like this has many more changes than you anticipated, please pare this down to the changes you need

@pankajsn
Copy link
Contributor Author

I have a created a new request #2528#2528 to exclude commits outside of our folder as suggested.
Just wondering why this pull request is labeled as “cla-required”

From: Mark Cowlishaw [mailto:[email protected]]
Sent: Tuesday, June 28, 2016 8:00 PM
To: Azure/azure-powershell [email protected]
Cc: Pankaj Singh Negi [email protected]; Mention [email protected]
Subject: Re: [Azure/azure-powershell] LogicApp/IntegrationAccount PSCmdlets (#2495)

@pankajsnhttps://github.com/pankajsn This has way too many changes outside your folder.

First: Please squash the commits 91 commits is too many for a cmdlet update
Second: It looks like this has many more changes than you anticipated, please pare this down to the changes you need

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/2495#issuecomment-229243840, or mute the threadhttps://github.com/notifications/unsubscribe/APZfc0POPKcyN5Pc_nwONCuslZAgpPqyks5qQd-egaJpZM4I8B5c.

@markcowl
Copy link
Member

Closing in favor of the other PR.

@markcowl markcowl closed this Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.