-
Notifications
You must be signed in to change notification settings - Fork 4k
ADL PowerShell Updates #2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ADL PowerShell Updates #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
begoldsm
commented
Jun 23, 2016
- Update to latest SDK
- Enable File and Folder performant download support
- Add a full path property to ADLS items returned with GET and LIST
- Update the help for new properties/property documentation changes
- Add default values for Upload and download for threading and number of files to download/upload at once during a folder upload/download
- Set the max connections for the ADLS client during client creation to 1000. This ensures the connection limit is high enough before any other ADLS calls are made, enabling upload/download to open sufficient connections.
- Remove tracing from file/folder copy until issue: ServiceClientTracingInterceptor consumes lots of memory for cmdlets with large response bodies #2499 is resolved.
Tests will be in the next iteration.
This is important to ensure that we have enough connections available for ingress/egress scenarios, and it must be set before the client is first used.
@begoldsm Please enable your tests here: https://github.com/Azure/azure-powershell/blob/dev/AzurePowershell.Test.targets#L94 |
This enables ADL tests to run during CI and gets them totally updated.
Following the pattern from compute tests.
This is a requirement for the tests to be discovered when run in playback mode.
This updates the change log to reflect the changes made Fixes to datetime offset for listing jobs fix to import/export logic due to inverted parameters.
# Conflicts: # AzurePowershell.Test.targets # ChangeLog.md
Inside of ACLs we allow ":", which breaks the playback of tests, since it encodes ":", which results in a missed match in the recorded json (which contains the colon). This fixes that so playback does not encode colons for paths that start with: /webhdfs/v1/?aclspec
LGTM once the on-demand run passes |
On demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/964/ |
@markcowl great, thanks Mark! I will keep an eye on it and post here once on demand passes. |
@markcowl on demand has passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.