-
Notifications
You must be signed in to change notification settings - Fork 4k
[RS Backup] Azure SQL workload support and new features in Azure VM workload #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2.Added capability to specify retention of recovery point during backup 3.Added backup support for Encrypted VMs in the Azure VM workload
…ng storage package in package.config
Can one of the admins verify this patch? |
@azuresdkci add to whitelist |
@@ -153,6 +157,24 @@ public static PolicyBase GetPolicyModel(ServiceClientModel.ProtectionPolicyResou | |||
iaasPolicyModel.SchedulePolicy = PolicyHelpers.GetPSSimpleSchedulePolicy((ServiceClientModel.SimpleSchedulePolicy) | |||
((ServiceClientModel.AzureIaaSVMProtectionPolicy)serviceClientResponse.Properties).SchedulePolicy); | |||
} | |||
else if (serviceClientResponse.Properties.GetType() == typeof(ServiceClientModel.AzureSqlProtectionPolicy)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line breaks
@pragrawa Please uncomment your test assembly here,https://github.com/Azure/azure-powershell/blob/dev/AzurePowershell.Test.targets#L100 so your tests will run as part of check-in and other runs. Note that, your team never added your tests to this file, or checked that the tests were running in test logs.. |
/// </summary> | ||
public class KeyAndSecretDetails | ||
{ | ||
/// <summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More info than just the acronym, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@@ -110,6 +110,10 @@ public override void ExecuteCmdlet() | |||
serviceClientProviderType = | |||
ServiceClientHelpers.GetServiceClientProviderType(Models.WorkloadType.AzureVM); | |||
} | |||
else if (WorkloadType == Models.WorkloadType.AzureSQLDatabase) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line breaks
Adding summary to public functions for Azure sql
…age for blob storage account, making resource id parsing generic
1. Long line breaks. Set 100 as the line length limit 2. Fixed bug: Get-AzureRmRecoveryServicesBackupContainer printing internal Vm Unique Id as Name 3. Added Deprecation message for Name filter in Get-AzureRmRecoveryServicesBackupContainer and introduced FriendlyName filter 4. Fixed resource group filter case-sensitive issue in Get-Item cmdlet
@pragrawa Comments on your comments and your tests are failing. Please fix. |
…ix and those changes are already part of the current branch.
…n get_available_location function
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/954/ |
…ntainerName and ItemName in Powershell
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/969/ @pragrawa Note that, it you add commits, we have to re-review them and rerun the test suite. |
@pragrawa Please update from the tip of the branch, there is a fix there |
No description provided.