Skip to content

[RS Backup] Azure SQL workload support and new features in Azure VM workload #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 1, 2016

Conversation

pragrawa
Copy link
Contributor

No description provided.

pragrawa added 2 commits June 27, 2016 15:17
2.Added capability to specify retention of recovery point during backup
3.Added backup support for Encrypted VMs in the Azure VM workload
@azuresdkci
Copy link

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor

hovsepm commented Jun 27, 2016

@azuresdkci add to whitelist

@@ -153,6 +157,24 @@ public static PolicyBase GetPolicyModel(ServiceClientModel.ProtectionPolicyResou
iaasPolicyModel.SchedulePolicy = PolicyHelpers.GetPSSimpleSchedulePolicy((ServiceClientModel.SimpleSchedulePolicy)
((ServiceClientModel.AzureIaaSVMProtectionPolicy)serviceClientResponse.Properties).SchedulePolicy);
}
else if (serviceClientResponse.Properties.GetType() == typeof(ServiceClientModel.AzureSqlProtectionPolicy))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line breaks

@markcowl
Copy link
Member

@pragrawa Please uncomment your test assembly here,https://github.com/Azure/azure-powershell/blob/dev/AzurePowershell.Test.targets#L100 so your tests will run as part of check-in and other runs. Note that, your team never added your tests to this file, or checked that the tests were running in test logs..

/// </summary>
public class KeyAndSecretDetails
{
/// <summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More info than just the acronym, please

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -110,6 +110,10 @@ public override void ExecuteCmdlet()
serviceClientProviderType =
ServiceClientHelpers.GetServiceClientProviderType(Models.WorkloadType.AzureVM);
}
else if (WorkloadType == Models.WorkloadType.AzureSQLDatabase)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line breaks

swatimadhukargit and others added 7 commits June 29, 2016 04:35
Adding summary to public functions for Azure sql
…age for blob storage account, making resource id parsing generic
1. Long line breaks. Set 100 as the line length limit
2. Fixed bug: Get-AzureRmRecoveryServicesBackupContainer printing internal Vm Unique Id as Name
3. Added Deprecation message for Name filter in Get-AzureRmRecoveryServicesBackupContainer and introduced FriendlyName filter
4. Fixed resource group filter case-sensitive issue in Get-Item cmdlet
@markcowl
Copy link
Member

@pragrawa Comments on your comments and your tests are failing. Please fix.

@markcowl
Copy link
Member

markcowl commented Jun 30, 2016

@markcowl
Copy link
Member

markcowl commented Jul 1, 2016

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/969/

@pragrawa Note that, it you add commits, we have to re-review them and rerun the test suite.

@markcowl
Copy link
Member

markcowl commented Jul 1, 2016

@pragrawa Please update from the tip of the branch, there is a fix there

@markcowl markcowl merged commit f58f00b into Azure:dev Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants