Skip to content

Remove Location Restriction from All Cmdlets for AzureChinaCloud #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2016

Conversation

solankisamir
Copy link
Member

All Cmdlets have Location check for Public Cloud Region, which is not needed for powershell to be compatible in both Public and AzureChinaCloud. The RP is doing that validation.

@azurecla
Copy link

Hi @solankisamir, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@solankisamir
Copy link
Member Author

solankisamir commented Jun 30, 2016

@markcowl
Copy link
Member

markcowl commented Jul 1, 2016

@solankisamir Please pull the latest - test failures look like a potential merge issue

@solankisamir
Copy link
Member Author

started another on-demand run after merging to latest.
http://azuresdkci.cloudapp.net/job/powershell-demand/962/

@markcowl
Copy link
Member

markcowl commented Jul 1, 2016

finally! This is the hard luck PR that hit every flaky test

@markcowl markcowl merged commit 4628bef into Azure:dev Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants