added generated files #25401
Merged
added generated files #25401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzNginxCertificate | Get-AzNginxCertificate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNginxCertificate | Get-AzNginxCertificate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzNginxConfiguration | Get-AzNginxConfiguration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNginxConfiguration | Get-AzNginxConfiguration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzNginxDeployment | Get-AzNginxDeployment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzNginxDeployment | Get-AzNginxDeployment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzNginxConfigurationFileObject | New-AzNginxConfigurationFileObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzNginxNetworkProfileObject | New-AzNginxNetworkProfileObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzNginxPrivateIPAddressObject | New-AzNginxPrivateIPAddressObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzNginxPublicIPAddressObject | New-AzNginxPublicIPAddressObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzNginxConfiguration 1 1 Unassigned_Variable New-AzNginxConfiguration -File $confFile is a null-valued parameter value. -File Assign value for $confFile. ⚠️ New-AzNginxDeployment 1 1 Unassigned_Variable New-AzNginxDeployment -NetworkProfile $networkProfile is a null-valued parameter value. -NetworkProfile Assign value for $networkProfile.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Nginx. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 53.33 % 92.86% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 53.33% 92.86% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 53.33% 92.86% Test coverage cannot be lower than the number of the last release.
VeryEarly
reviewed
Jun 28, 2024
src/Nginx/Nginx.Autorest/README.md
Outdated
|
|
||
| root-module-name: $(prefix).Nginx | ||
| title: Nginx | ||
| module-version: 0.1.0 | ||
| module-version: 0.1.1 |
There was a problem hiding this comment.
please leave this version as it was
VeryEarly
reviewed
Jun 28, 2024
| @@ -0,0 +1,22 @@ | |||
| ### Example 1: {{ Add title here }} | |||
There was a problem hiding this comment.
please fill out this file and run build-module.ps1 to update the doc
|
please re-record tests after API upgrade |
…24-01-01-preview into 2024-01-01-preview
VeryEarly
reviewed
Jul 30, 2024
| $keyVaultId = $keyVault.ResourceId | ||
| $roleDefinition = Get-AzRoleDefinition -Name "Key Vault Administrator" | ||
| $roleAssignment = New-AzRoleAssignment -ObjectId $nginxDeployment.IdentityPrincipalId -RoleDefinitionId $roleDefinition.Id -Scope $keyVaultId | ||
|
|
||
| } | ||
| function cleanupEnv() { | ||
| # Clean resources you create for testing |
There was a problem hiding this comment.
you might want to clean up resources created in setupEnv() here
VeryEarly
approved these changes
Jul 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.