Adding code to remove dependency with AzureKeyVaultServiceEndpointResourceId #2544
Conversation
…KeyVaultServiceEndpointResourceId of Get-AzureRmEnvironment. The keyvault resource Id is now obtained from server using 401 challenge. The Azure PowerShell common infrastructure currently do not support this in an intuitive fashion, so tweaking its usage by overriding the environment endpoint value before acquiring the token.
|
Hi @jkapil, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
| @@ -74,14 +84,18 @@ public Task<string> OnAuthentication(string authority, string resource, string s | |||
| throw new ArgumentException(string.Format(KeyVaultProperties.Resources.UnsupportedAccountType, context.Account.Type)); | |||
|
|
|||
| if (context.Subscription != null && context.Account != null) | |||
| TenantId = context.Subscription.GetPropertyAsArray(AzureSubscription.Property.Tenants) | |||
| tenantId = context.Subscription.GetPropertyAsArray(AzureSubscription.Property.Tenants) | |||
There was a problem hiding this comment.
Why not use context.tenant as the first option?
There was a problem hiding this comment.
We might, didn't wanted to change logic for tenant ID
There was a problem hiding this comment.
Yes this will be integrated into release 1.2.4
|
@jkapil one minor comment. I would really like to see a mocked test for the scenario - can you mock this by mocking out the authentication factory? |
|
@jkapil is this also intended for AzureStack TP2? If so, you'll need to open a PR against the release-1.2.4 branch |
Adding code to remove dependency with static value specified in AzureKeyVaultServiceEndpointResourceId of Get-AzureRmEnvironment. The keyvault resource Id is now obtained from server using 401 challenge. The Azure PowerShell common infrastructure currently do not support this in an intuitive fashion, so tweaking its usage by overriding the environment endpoint value before acquiring the token.