Skip to content

[Release 1.6.0] [AzureRT] Sprint 61 #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 6, 2016
Merged

Conversation

hyonholee
Copy link
Contributor

  • Add ADDomain extension cmdlets
  • Set-AzureRmVMCustomScriptExtension is not throwing non-terminating error if the operation is not successful
  • New-AzureRmVM can gets the value of license type from VM object
  • Name and Version are back to optional for set extension cmdlets.

@hovsepm hovsepm changed the title [AzureRT] Sprint 61 [Release 1.6.0] [AzureRT] Sprint 61 Jul 6, 2016
@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

    DefaultParameterSetName = SettingsParamSet)]

you need to add SupportsShouldProcess = true to the attributes #Closed


Refers to: src/ResourceManager/Compute/Commands.Compute/Extension/SetAzureVMExtensionCommand.cs:28 in b5558e7. [](commit_id = b5558e7, deletion_comment = False)

{
[Cmdlet(
VerbsCommon.Set,
ProfileNouns.VirtualMachineADDomainExtension)]
Copy link
Contributor

@hovsepm hovsepm Jul 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add SupportsShouldProcess = true to the attributes #Closed

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

    ProfileNouns.VirtualMachineBgInfoExtension)]

add SupportsShouldProcess = true to the attributes #Closed


Refers to: src/ResourceManager/Compute/Commands.Compute/Extension/BGInfo/SetAzureVMBGInfoExtension.cs:25 in b5558e7. [](commit_id = b5558e7, deletion_comment = False)

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

    DefaultParameterSetName = SetCustomScriptExtensionByContainerBlobsParamSetName)]

add SupportsShouldProcess = true to the attributes #Closed


Refers to: src/ResourceManager/Compute/Commands.Compute/Extension/CustomScript/SetAzureVMCustomScriptExtensionCommand.cs:34 in b5558e7. [](commit_id = b5558e7, deletion_comment = False)

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

    ProfileNouns.VirtualMachineAccessExtension)]

add SupportsShouldProcess = true to the attributes #Closed


Refers to: src/ResourceManager/Compute/Commands.Compute/Extension/VMAccess/SetAzureVMAccessExtension.cs:26 in b5558e7. [](commit_id = b5558e7, deletion_comment = False)

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

[Cmdlet("New", "AzureRmContainerService", DefaultParameterSetName = "InvokeByDynamicParameters")]

add SupportsShouldProcess = true to the attributes #Closed


Refers to: src/ResourceManager/Compute/Commands.Compute/Generated/ContainerService/ContainerServiceCreateOrUpdateMethod.cs:116 in b5558e7. [](commit_id = b5558e7, deletion_comment = False)

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

[Cmdlet("New", "AzureRmVmss", DefaultParameterSetName = "InvokeByDynamicParameters")]

add SupportsShouldProcess = true to the attributes #Closed


Refers to: src/ResourceManager/Compute/Commands.Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetCreateOrUpdateMethod.cs:116 in b5558e7. [](commit_id = b5558e7, deletion_comment = False)

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

[Cmdlet(VerbsCommon.New, ProfileNouns.VirtualMachine)]

add SupportsShouldProcess = true to the attributes #Closed


Refers to: src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs:32 in b5558e7. [](commit_id = b5558e7, deletion_comment = False)

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

[Cmdlet(VerbsData.Update, ProfileNouns.VirtualMachine, DefaultParameterSetName = ResourceGroupNameParameterSet)]

add SupportsShouldProcess = true to the attributes #Closed


Refers to: src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/UpdateAzureVMCommand.cs:24 in b5558e7. [](commit_id = b5558e7, deletion_comment = False)

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

@hovsepm hovsepm merged commit 5c84f5d into Azure:release-1.6.0 Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants