Skip to content

[Release 1.6.0] Updating DNS powershell to new SDK #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jul 7, 2016

Conversation

vladrai
Copy link
Contributor

@vladrai vladrai commented Jul 6, 2016

No description provided.

Karthikeyan Nenmeli Ravichandran and others added 29 commits April 12, 2016 10:49
# Conflicts:

#	src/ResourceManager/Common/Commands.ScenarioTests.ResourceManager.Common/packages.config
#	src/ResourceManager/Dns/Commands.Dns.Test/packages.config
@azurecla
Copy link

azurecla commented Jul 6, 2016

Hi @vladrai, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm hovsepm changed the title Updating DNS powershell to new SDK [Release 1.6.0] Updating DNS powershell to new SDK Jul 6, 2016
@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

@azuresdkci add to whitelist

@hovsepm
Copy link
Contributor

hovsepm commented Jul 6, 2016

[Cmdlet(VerbsCommon.Remove, "AzureRmDnsZone", SupportsShouldProcess = true),

please implement ShouldProcess correctly. #Closed


Refers to: src/ResourceManager/Dns/Commands.Dns/Zones/RemoveAzureDnsZone.cs:27 in 3d49692. [](commit_id = 3d49692, deletion_comment = False)

@@ -191,6 +215,7 @@
<None Include="..\..\Common\Commands.ScenarioTests.ResourceManager.Common\AzureRM.Resources.ps1">
<Link>ScenarioTests\AzureRM.Resources.ps1</Link>
</None>
<None Include="app.config" />
<None Include="MSSharedLibKey.snk" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove app.config from csproj.

@hovsepm
Copy link
Contributor

hovsepm commented Jul 7, 2016

@hovsepm
Copy link
Contributor

hovsepm commented Jul 7, 2016

@vladrai on-demand job failed. you need to set location of the session records relative to your Assembly location. Take a look here -

HttpMockServer.RecordsDirectory = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "SessionRecords");

@vladrai
Copy link
Contributor Author

vladrai commented Jul 7, 2016

Updated PR to have script directory setup

@hovsepm
Copy link
Contributor

hovsepm commented Jul 7, 2016

@hovsepm hovsepm merged commit b34b213 into Azure:release-1.6.0 Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants