Skip to content

Rely on "ReferenceName" property to get fully qualified extension name; Status Message's name changes from "Automatic to Automated" #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 23, 2015
Merged

Rely on "ReferenceName" property to get fully qualified extension name; Status Message's name changes from "Automatic to Automated" #262

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3c1b70c
Merge pull request #1 from Azure/dev
sethusrinivasan Dec 8, 2014
63bcb7f
Merge pull request #2 from Azure/dev
sethusrinivasan Dec 13, 2014
600e527
Merge pull request #3 from Azure/dev
sethusrinivasan Dec 15, 2014
51f23e1
Merge pull request #4 from Azure/dev
sethusrinivasan Dec 18, 2014
c22dc7f
Merge pull request #5 from Azure/dev
sethusrinivasan Dec 18, 2014
aa7b8ec
Merge pull request #6 from Azure/dev
sethusrinivasan Jan 5, 2015
57c0b4f
Merge pull request #7 from Azure/dev
sethusrinivasan Jan 19, 2015
7c251db
Merge pull request #8 from Azure/dev
sethusrinivasan Jan 30, 2015
c559c1c
Merge pull request #9 from Azure/dev
sethusrinivasan Feb 10, 2015
db92ee8
Merge pull request #10 from Azure/dev
sethusrinivasan Feb 25, 2015
f558ce2
Merge pull request #11 from Azure/dev
sethusrinivasan Mar 9, 2015
3bd386d
Merge pull request #12 from Azure/dev
sethusrinivasan Mar 11, 2015
3cbb7ff
Merge pull request #13 from Azure/dev
sethusrinivasan Mar 12, 2015
b96f37f
Issues:
sethusrinivasan Mar 12, 2015
ee633f5
Merge pull request #14 from Azure/dev
sethusrinivasan Mar 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions ...pute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/GetAzureVMSqlServerExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ namespace Microsoft.WindowsAzure.Commands.ServiceManagement.IaaS.Extensions
public class GetAzureVMSqlServerExtensionCommand : VirtualMachineSqlServerExtensionCmdletBase
{
protected const string GetSqlServerExtensionParamSetName = "GetSqlServerExtension";
protected const string AutoPatchingStatusMessageName = "Automatic Patching";
protected const string AutoBackupStatusMessageName = "Automatic Backup";
protected const string AutoPatchingStatusMessageName = "Automated Patching";
protected const string AutoBackupStatusMessageName = "Automated Backup";

internal void ExecuteCommand()
{
Expand Down Expand Up @@ -89,18 +89,15 @@ private VirtualMachineSqlServerExtensionContext GetExtensionContext(ResourceExte
// Note: valid reference to an extension status list is returned by GetResourceExtensionStatusList()
foreach (NSM.ResourceExtensionStatus res in extensionStatusList)
{
// Extension handler name in format publisher.ReferenceName
string extensionHandlerName = string.Format(CultureInfo.InvariantCulture,
"{0}.{1}",
r.Publisher,
r.ReferenceName);

// skip all non-sql extensions
if (!res.HandlerName.Equals(extensionHandlerName, System.StringComparison.InvariantCulture))
// Expected ReferenceName = "Microsoft.SqlServer.Management.SqlIaaSAgent"
if (!res.HandlerName.Equals(r.ReferenceName, System.StringComparison.InvariantCulture))
{
// skip all non-sql extensions
continue;
}

WriteVerboseWithTimestamp("Found SQL Extension:" + r.ReferenceName);

if (null != res.ExtensionSettingStatus)
{
context.SubStatusList = res.ExtensionSettingStatus.SubStatusList;
Expand Down