Skip to content

Remove the tags deprecation message from all cmdlets #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -35,9 +35,6 @@ public class GetBatchAccountCommand : BatchCmdletBase

public override void ExecuteCmdlet()
{
WriteWarning("WARNING: The usage of the Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags " +
"for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494 ");

if (string.IsNullOrEmpty(this.AccountName))
{
foreach (BatchAccountContext context in BatchClient.ListAccounts(Tag, this.ResourceGroupName))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -46,9 +46,6 @@ public class NewBatchAccountCommand : BatchCmdletBase

public override void ExecuteCmdlet()
{
WriteWarning("WARNING: The usage of the Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags " +
"for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494 ");

BatchAccountContext context = BatchClient.CreateAccount(this.ResourceGroupName, this.AccountName, this.Location, this.Tag, this.AutoStorageAccountId);
WriteObject(context);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -41,9 +41,6 @@ public class SetBatchAccountCommand : BatchCmdletBase

public override void ExecuteCmdlet()
{
WriteWarning("WARNING: The usage of the Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags " +
"for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494 ");

BatchAccountContext context = BatchClient.UpdateAccount(this.ResourceGroupName, this.AccountName, this.Tag, this.AutoStorageAccountId);
WriteObject(context);
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -511,9 +511,6 @@ The file needs to be a PowerShell script (.ps1 or .psm1) or a ZIP archive (.zip)
<value>Error occurred when choosing existing standard storage account for boot diagnostics: {0}</value>
<comment>{0} = an error message</comment>
</data>
<data name="TagFixWarningMessage" xml:space="preserve">
<value>The usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494</value>
</data>
<data name="DisableDiskEncryptionAction" xml:space="preserve">
<value>Disable disk encryption</value>
</data>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ public class NewAzureVMCommand : VirtualMachineBaseCmdlet

public override void ExecuteCmdlet()
{
WriteWarning(Properties.Resources.TagFixWarningMessage);

base.ExecuteCmdlet();

if (this.VM.DiagnosticsProfile == null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public override void ExecuteCmdlet()
{
ExecuteClientAction(() =>
{
WriteWarning(Properties.Resources.TagFixWarningMessage);
var parameters = new VirtualMachine
{
DiagnosticsProfile = this.VM.DiagnosticsProfile,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ public class NewAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase

public override void ExecuteCmdlet()
{
if (Tags != null && Tags.Length > 0)
{
WriteWarningWithTimestamp(Properties.Resources.TagsWarning);
}

try
{
if (DataLakeAnalyticsClient.GetAccount(ResourceGroupName, Name) != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ public class SetAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase

public override void ExecuteCmdlet()
{
if (Tags != null && Tags.Length > 0)
{
WriteWarningWithTimestamp(Properties.Resources.TagsWarning);
}

DataLakeStoreAccountInfo defaultAccount = null;
if (!string.IsNullOrEmpty(DefaultDataLakeStore))
{
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,4 @@
<data name="RemovingDataLakeAnalyticsCatalogSecrets" xml:space="preserve">
<value>Are you sure you want to remove ALL Data Lake Analytics catalog secrets in database '{0}'?</value>
</data>
<data name="TagsWarning" xml:space="preserve">
<value>The usage of 'Tags' parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494</value>
</data>
</root>
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@ public class NewAzureDataLakeStoreAccount : DataLakeStoreCmdletBase

public override void ExecuteCmdlet()
{
if(Tags != null && Tags.Length > 0)
{
WriteWarningWithTimestamp(Resources.TagsWarning);
}

try
{
if (DataLakeStoreClient.GetAccount(ResourceGroupName, Name) != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,6 @@ public class SetAzureDataLakeStoreAccount : DataLakeStoreCmdletBase

public override void ExecuteCmdlet()
{
if (Tags != null && Tags.Length > 0)
{
WriteWarningWithTimestamp(Properties.Resources.TagsWarning);
}

var currentAccount = DataLakeStoreClient.GetAccount(ResourceGroupName, Name);
var location = currentAccount.Location;

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,6 @@
<data name="SettingDataLakeStoreItemOwner" xml:space="preserve">
<value>Are you sure you want to replace the existing owning group or user at the Data Lake item at path: '{0}'?</value>
</data>
<data name="TagsWarning" xml:space="preserve">
<value>The usage of 'Tags' parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494</value>
</data>
<data name="TaskCancelledMessage" xml:space="preserve">
<value>The operation is being cancelled, please wait...</value>
</data>
Expand Down
4 changes: 2 additions & 2 deletions src/ResourceManager/Dns/Commands.Dns/Zones/NewAzureDnsZone.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -39,7 +39,7 @@ public class NewAzureDnsZone : DnsBaseCmdlet

public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
WriteWarning("The output object type of this cmdlet will be modified in a future release.");

if (this.Name.EndsWith("."))
{
Expand Down
4 changes: 2 additions & 2 deletions src/ResourceManager/Dns/Commands.Dns/Zones/SetAzureDnsZone.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -46,7 +46,7 @@ public class SetAzureDnsZone : DnsBaseCmdlet

public override void ExecuteCmdlet()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
WriteWarning("The output object type of this cmdlet will be modified in a future release.");

DnsZone result = null;
DnsZone zoneToUpdate = null;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -75,8 +75,6 @@ public class GetAzureKeyVault : KeyVaultManagementCmdletBase
#endregion
public override void ExecuteCmdlet()
{
WriteWarning("The usage of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");

switch (ParameterSetName)
{
case GetVaultParameterSet:
Expand All @@ -103,4 +101,4 @@ public override void ExecuteCmdlet()
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -94,8 +94,6 @@ public class NewAzureKeyVault : KeyVaultManagementCmdletBase

public override void ExecuteCmdlet()
{
WriteWarning("The usage of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");

if (VaultExistsInCurrentSubscription(this.VaultName))
{
throw new ArgumentException(PSKeyVaultProperties.Resources.VaultAlreadyExists);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -132,7 +132,7 @@ public override void ExecuteCmdlet()
{
base.ExecuteCmdlet();

WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
var present = this.IsApplicationGatewayPresent(this.ResourceGroupName, this.Name);
ConfirmAction(
Force.IsPresent,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -114,7 +114,7 @@ public class NewAzureExpressRouteCircuitCommand : ExpressRouteCircuitBaseCmdlet

public override void Execute()
{
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
var present = this.IsExpressRouteCircuitPresent(this.ResourceGroupName, this.Name);
ConfirmAction(
Force.IsPresent,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -100,7 +100,7 @@ public class NewAzureLoadBalancerCommand : LoadBalancerBaseCmdlet
public override void Execute()
{
base.Execute();
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
var present = this.IsLoadBalancerPresent(this.ResourceGroupName, this.Name);
ConfirmAction(
Force.IsPresent,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -94,7 +94,7 @@ public class NewAzureLocalNetworkGatewayCommand : LocalNetworkGatewayBaseCmdlet
public override void Execute()
{
base.Execute();
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
var present = this.IsLocalNetworkGatewayPresent(this.ResourceGroupName, this.Name);
ConfirmAction(
Force.IsPresent,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@



// ----------------------------------------------------------------------------------
//
Expand Down Expand Up @@ -220,7 +220,7 @@ public class NewAzureNetworkInterfaceCommand : NetworkInterfaceBaseCmdlet
public override void Execute()
{
base.Execute();
WriteWarning("The output object type of this cmdlet will be modified in a future release. Also, the usability of Tag parameter in this cmdlet will be modified in a future release. This will impact creating, updating and appending tags for Azure resources. For more details about the change, please visit https://github.com/Azure/azure-powershell/issues/726#issuecomment-213545494");
WriteWarning("The output object type of this cmdlet will be modified in a future release.");
var present = this.IsNetworkInterfacePresent(this.ResourceGroupName, this.Name);
ConfirmAction(
Force.IsPresent,
Expand Down
Loading