Changes for end to end ssl and SSLPolicy in application gateways #2684
Conversation
|
Hi @vinatara, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@vinatara @vinayada Please coordinate, or neither of your PRs will be merged. |
|
@vinatara It looks like you need to publish the new version of the network package: EXEC : warning : Unable to find version '6.0.2-preview' of package 'Microsoft.Azure.Management.Network'. [D:\workspace\powershell\build.proj] |
|
Please make sure that this file is not a certifciate used for credentials anywhere: ResourceManager/Network/Commands.Network.Test/ScenarioTests/Data/ApplicationGatewayAuthCert.cer |
|
|
||
| namespace Microsoft.Azure.Commands.Network | ||
| { | ||
| [Cmdlet(VerbsCommon.Add, "AzureRmApplicationGatewayAuthenticationCertificate"), OutputType(typeof(PSApplicationGateway))] |
There was a problem hiding this comment.
Add SupportsShouldProcess = true to the Cmdlet attribute
There was a problem hiding this comment.
These are child resources of application gateway. I don't see SupportsShouldProcess being added to any other child resources (e.g. AddAzureLoadBalancerBackendAddressPoolConfigCommand.cs for load balancer child resource). Also VS says it cannot resolve SupportsShouldProcess in this file.
|
@vinatara some comments. See: https://gist.github.com/markcowl/338e16fe5c8bbf195aff9f8af0db585d For a detailed discussion of PowerShell Confirmation. Note that the build will fail if you do not add help for the new cmdlets as well. |
| @@ -15,6 +15,7 @@ | |||
| <RestorePackages>true</RestorePackages> | |||
There was a problem hiding this comment.
Revert any changes to this file
| @@ -197,4 +197,11 @@ | |||
| </ItemGroup> | |||
| <ItemGroup /> | |||
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | |||
| </Project> | |||
| <Import Project="$(SolutionDir)\.nuget\NuGet.targets" Condition="Exists('$(SolutionDir)\.nuget\NuGet.targets')" /> | |||
|
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1063/ LGTM once the build passes |
The build will fail because the SDK package has not been published yet. Please look at changes and provide comments.