-
Notifications
You must be signed in to change notification settings - Fork 4k
Update AD Graph Cmdlets #2734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AD Graph Cmdlets #2734
Conversation
…dential management cmdlets, and manage user cmdlets
Hi @shuagarw, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
/// <summary> | ||
/// Creates a new AD application Credential. | ||
/// </summary> | ||
[Cmdlet(VerbsCommon.New, "AzureRmADAppCredential", DefaultParameterSetName = ParameterSet.ApplicationObjectIdWithPassword), OutputType(typeof(PSADCredential))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SupportsShouldProcess=true
@shuagarw The issue is that you have removed the quotes from the csv file unintentionally while saving it. You can import the file into excel, add your columns, and save as a csv. |
@markcowl Thanks!! I was looking into it and trying to find what I messed up in csv file as it is not able to parse. |
@shuagarw if you make the SHouldProcess changes I outlined in review comments, the other static analysis error will go away. The P0 in SignautreIssues.csv is that your new Remove cmdlets have Force parameters but do not have the SupportsShouldProcess=true property in the cmdlet attribute |
@shuagarw It looks like it was unable to find the mocks for one of your tests. This either means that the file isn't marked as CopyIfNewer or CopyAlways, or the file path is too long and you'll need to shorten the test class or test name |
New on-demand after some small fixes: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1084/ |
LGTM once the build passes |
Update AD Graph Cmdlets: