Skip to content

[HDINSIGHT] NullRef SShCreds bug #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2016
Merged

[HDINSIGHT] NullRef SShCreds bug #2744

merged 2 commits into from
Aug 30, 2016

Conversation

nemanja88
Copy link
Contributor

Fixing a bug where a null ref was thrown when SSh is not provided for Linux clusters.

@azurecla
Copy link

azurecla commented Aug 8, 2016

Hi @nemanja88, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (nemadj). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci
Copy link

Can one of the admins verify this patch?

@shahabhijeet
Copy link
Contributor

@azuresdkci test this please

1 similar comment
@shahabhijeet
Copy link
Contributor

@azuresdkci test this please

@shahabhijeet
Copy link
Contributor

@nemanja88 I don't see any test coverage for this case, as it seems like you fixed a null ref issue.

@markcowl
Copy link
Member

@nemanja88 Please add test coverage to prevent regressions.

@markcowl
Copy link
Member

@nemanja88 Please respond. We will have to close this PR at EOW if there is no response to review comments.

@markcowl
Copy link
Member

@azuresdkci add to whitelist

@markcowl markcowl merged commit 8dd308b into Azure:dev Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants