Add check to signing builds for strong name signature #2790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -258,6 +258,8 @@ | |||
| ContinueOnError="false" | |||
| Condition="!$(DelaySign) and '@(DelaySignedAssembliesToSign)' != ''"/> | |||
|
|
|||
| <Exec Command="$(MSBuildProjectDirectory)\tools\CheckStrongNameSignature.ps1"/> | |||
There was a problem hiding this comment.
See: https://github.com/cormacpayne/azure-powershell/blob/5043c685511c5fc8d678a4e245c9bdfa41ad83ff/build.proj#L308 for how to run powershell and refer to the tools folder in a task
There was a problem hiding this comment.
@cormacpayne any reason we need the ps1 file, rather than adding the same code in the ValidateStrongNameSignatureTask ?
|
signing build here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/580/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2762