Skip to content

Fixing restore and recovery bug #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Conversation

mkherani
Copy link
Member

No description provided.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@markcowl
Copy link
Member

@azuresdkci add to whitelist

@markcowl markcowl changed the title Fixing restore and recovery bug https://microsoft.visualstudio.com/we… Fixing restore and recovery bug Aug 24, 2016
@markcowl
Copy link
Member

markcowl commented Aug 24, 2016

@mkherani Please include tests to catch this bug and prevent regressions. Also, please fill in the checklist below:

This checklist is used to make sure that common issues in a pull request are covered by the creator. You can find a more complete discussion of PowerShell cmdlet best practices here.

Below in Overall Changes, check off the boxes that apply to your PR. Within each of the categories that you select, make sure that you can check off all of the boxes.

Overall Changes

General

  • Title of the PR is clear and informative
  • There are a small number of commits that each have an informative message
  • If it applies, references the bug/issue that the PR fixes
  • All files have the Microsoft copyright header
  • Cmdlets refer to management libraries through nuget references - no dlls are checked in
  • The PR does not introduce breaking changes (unless a major version change occurs in the assembly and module)

Tests

  • PR includes test coverage for the included changes
  • Tests must use xunit, and should either use Moq to mock management client calls, or use the scenario test framework
  • PowerShell scripts used in tests must not use hard-coded values for location
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for existing resources
  • Tests should not use App.config files for settings
  • Tests should use the built-in PowerShell functions for generating random names when unique names are necessary - this will store names in the test recording
  • Tests should use Start-Sleep to pause rather than Thread.Sleep

@mkherani
Copy link
Member Author

@markcowl Added the test coverage. Please Merge the PR.

@markcowl
Copy link
Member

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1108/

LGTM once this passes. Note that you might need to rebase on the latest commit for this to pass

@mkherani
Copy link
Member Author

@markcowl Thanks!! On demand run was green. I did rebase to latest commit as well. Please merge the PR once the run will be green.

@markcowl markcowl merged commit b851042 into Azure:dev Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants