-
Notifications
You must be signed in to change notification settings - Fork 4k
AzureSQL - Adding ConfirmAction usage, threat detection policy for servers, blob auditing policy properties #2824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merging from upstream Azure
@yoavrubin - This has a lot of commits that are uninformative either rebase, or cherry-pick the commits into a new branch so that the commit history looks a bit better. |
@yoavrubin Please fill out the appropriate sections of the PR template: This checklist is used to make sure that common issues in a pull request are covered by the creator. You can find a more complete discussion of PowerShell cmdlet best practices here. Below in Overall Changes, check off the boxes that apply to your PR. Within each of the categories that you select, make sure that you can check off all of the boxes. Overall Changes
General
Tests
Cmdlet Signature
Parameters
Parameters and the Pipeline
|
{ | ||
break; | ||
} | ||
Task.Delay(2000); // wait 2 seconds between each poll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoavrubin Please use TestMockSupport.Delay() instead
ConfirmAction is now handled at the base class for all AzureSQL cmdlets.
Added AzureSQL threat detection policy management at the server level. This includes added tests and rerecording relevant tests.
Extended the storage related properties of blob auditing policy and rerecorded the auditing tests.