Skip to content

AzureSQL - Adding ConfirmAction usage, threat detection policy for servers, blob auditing policy properties #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Aug 25, 2016

Conversation

yoavrubin
Copy link
Member

@yoavrubin yoavrubin commented Aug 24, 2016

ConfirmAction is now handled at the base class for all AzureSQL cmdlets.
Added AzureSQL threat detection policy management at the server level. This includes added tests and rerecording relevant tests.
Extended the storage related properties of blob auditing policy and rerecorded the auditing tests.

@markcowl
Copy link
Member

markcowl commented Aug 24, 2016

@yoavrubin - This has a lot of commits that are uninformative either rebase, or cherry-pick the commits into a new branch so that the commit history looks a bit better.

@markcowl
Copy link
Member

markcowl commented Aug 24, 2016

@yoavrubin Please fill out the appropriate sections of the PR template:

This checklist is used to make sure that common issues in a pull request are covered by the creator. You can find a more complete discussion of PowerShell cmdlet best practices here.

Below in Overall Changes, check off the boxes that apply to your PR. Within each of the categories that you select, make sure that you can check off all of the boxes.

Overall Changes

General

  • Title of the PR is clear and informative
  • There are a small number of commits that each have an informative message
  • If it applies, references the bug/issue that the PR fixes
  • All files have the Microsoft copyright header
  • Cmdlets refer to management libraries through nuget references - no dlls are checked in
  • The PR does not introduce breaking changes (unless a major version change occurs in the assembly and module)

Tests

  • PR includes test coverage for the included changes
  • Tests must use xunit, and should either use Moq to mock management client calls, or use the scenario test framework
  • PowerShell scripts used in tests must not use hard-coded values for location
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for existing resources
  • Tests should not use App.config files for settings
  • Tests should use the built-in PowerShell functions for generating random names when unique names are necessary - this will store names in the test recording
  • Tests should use Start-Sleep to pause rather than Thread.Sleep

Cmdlet Signature

  • Cmdlet name uses an approved PowerShell verb - use the enums for VerbsCommon, VerbsCommunication, VerbsLifecycle, VerbsOther whenever possible
  • Cmdlet noun name uses the AzureRm prefix for management cmdlets, and the Azure prefix for data plane cmdlets
  • Cmdlet specifies the OutputType attribute if any output is produced; if the cmdlet produces no output, it should implement a PassThrough parameter
  • If the cmdlet makes changes or has side effects, it should implement ShouldProcess and have SupportShouldProcess = true specified in the cmdlet attribute. See a discussion about correct ShouldProcess implementation here
  • Cmdlets should derive from AzureRmCmdlet for management cmdlets, and AzureDataCmdlet for data cmdlets
  • If multiple parameter sets are implemented, the cmdlet should specify a DefaultParameterSetName in its cmdlet attribute

Parameters

  • Cmdlets should have no more than four positional parameters
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets
  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet
  • Parameters should be explicitly marked as Mandatory or not, and should contain a HelpMessage
  • No parameter is of type object.
    • Management cmdlets should have the following parameters and aliases:
      • ResourceGroupName with (optional) alias to ResourceGroup type string marked as [ValueFromPipelineByPropertyName]
      • Name with alias to ResourceName type string marked as [ValueFromPipelineByPropertyName]
      • Location (if appropriate) type string
      • Tag, type HashTable

Parameters and the Pipeline

  • Complex parameters should take values from the pipeline when possible, and certainly when they match the output type of another cmdlet
  • Only one parameter should use ValueFromPipeline per parameter set; parameters from different parameter sets may have this attribute, but should not be convertible
  • No parameter is of type object
  • Each management cmdlet should have a parameter set that takes ResourceGroupName and Name from the pipeline by property value
  • For a given resource type, it should be possible to pipe the output of Get and New cmdlets to the input of Set, Update, Remove and other action cmdlets for that resource

{
break;
}
Task.Delay(2000); // wait 2 seconds between each poll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavrubin Please use TestMockSupport.Delay() instead

@hovsepm hovsepm merged commit 83fa144 into Azure:dev Aug 25, 2016
@yoavrubin yoavrubin changed the title AzureSQL - ConfirmAction usage, threat detection policy for servers, blob auditing policy properties AzureSQL - Adding ConfirmAction usage, threat detection policy for servers, blob auditing policy properties Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants