Skip to content

Include environment name in the key of Api-Version cache. #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2016

Conversation

TianoMS
Copy link

@TianoMS TianoMS commented Aug 25, 2016

No description provided.

@markcowl
Copy link
Member

@TianoMS Thanks, Tiano, how are we testing this? How difficult would it be to add a regression test?
Also, can you add this to the release-1.2.4 branch as well?

@TianoMS
Copy link
Author

TianoMS commented Aug 25, 2016

@markcowl To test this we need an account which has subscriptions in a different environments. And we need to get a resource type which supports different versions in different environments, which is a very rare case. I tried to work this out but didn't succeed...

Right now I'm trying to ask the issue opener to get a consistent repro from their side. They didn't get back yet. Once I get that I'll see if I can build a test case from their scenario.

@TianoMS
Copy link
Author

TianoMS commented Aug 29, 2016

@markcowl I manually verified the fix with Bala's help. The fix works. Right now we don't have a good way to test it in an automation. We may have to skip it this time.

@markcowl
Copy link
Member

@TianoMS Please file an issue for this - it would be fine to have some separate tests of the caching mechanism rather than end-to-end test automation. Also, please fix in the release-1.2.4 branch as well.

@markcowl markcowl merged commit 1a5105d into Azure:dev Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants