Add support for querying encryption status from the AzureDiskEncryptionForLinux extension #2849
Conversation
Conflicts: src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/SetAzureDiskEncryptionExtension.cs
| Mandatory = false, | ||
| Position = 2, | ||
| ValueFromPipelineByPropertyName = true, | ||
| HelpMessage = "The extension name. If this parameter is not specified, default values used are AzureDiskEncryption for windows VMs and AzureDiskEncryptionForLinux for Linux VMs")] |
There was a problem hiding this comment.
capitalize "windows" -> "Windows"
|
@krkhan please respond to review comments. ALso, please clean up the number of commits and commit comments, by cherry-picking or rebasing the commits. |
|
@markcowl Addressed comments on both GH and CF. Added you to the CF review as well. |
|
on demand run here:http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1125/ LGTM once this passes |
|
@markcowl That error doesn't look related to disk encryption.
|
|
@krkhan It isn't, you need to rebase this change on the latest in the dev branch, as there is a fix for this issue there.on the |
|
@krkhan Hey Kamran, the test that is failing in your on-demand build has been fixed and merged into dev, so if you pull and rebase with dev, you should be fine. You can check out how to rebase in our cleaning up commits guide |
|
@krkhan, we can't merge until you do this |
|
There's a minor CR change that's needed. I'll do that today as well as merge upstream dev so that the fix is pulled in. |
|
@markcowl finished reviewing, looks good |
|
@markcowl The ondemand run you started succeeded: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1138/ |
Internal CR at CodeFlow:
codeflow:open?server=http://codeflow/Services/DiscoveryService.svc&review=kakhan-39e101815e2546efaaf9136c37643be7&alert=true