Move PaginatedResponseHelper class to Commands.Common #2868
Conversation
|
@NonStatic2014 Given that this is code complete, and this shouldn't be required for the release, we are likely not going to take this until after the release. |
|
This will go in for next sprint - discussed a change with Klein |
markcowl
changed the title
NonStatic2014
changed the title
|
On-demand build passed: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1176/ |
| @@ -183,4 +183,4 @@ | |||
| </ProjectReference> | |||
| </ItemGroup> | |||
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | |||
| </Project> | |||
| </Project> | |||
|
@vivsriaus Can you sign off on the changes to resource manager cmdlets? |
|
@NonStatic2014 A couple of minor comments from me, checking with Vivek on the resource manager changes. |
| @@ -26,6 +22,11 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
|
|
|||
| using Entities.Providers; | |||
There was a problem hiding this comment.
Can you please sort the usings for all these files?
There was a problem hiding this comment.
Visual Studio prefer "System.xxx" on top and then other using in alphabet order.
|
@NonStatic2014 please address code review feedback. |
|
On demand build passed: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1181 |
| using System.Linq; | ||
| using System.Management.Automation; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.Azure.Commands.ResourceManager.Common; |
There was a problem hiding this comment.
Please reorder the usings
|
@NonStatic2014 LGTM, pending one minor nit. |
Paginated response from a web service is a common case. So the helper class to take care this situation should also be in a common place. This change is to move it from ResourceManager cmdlet to Commands.Common. Machine Learning cmdlet will consume it later.
All tests under Resource Manager cmdlet have been run locally. No failed cases (129 passed, 25 skipped).