Skip to content

ADL Updates to latest Package #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 7, 2016
Merged

ADL Updates to latest Package #2892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8d87ffa
Update PowerShell to use the latest SDK
Jun 17, 2016
23d2ddf
ADL PowerShell updates for code freeze
begoldsm Sep 1, 2016
2444c9b
Initial package updates for ADL PS
begoldsm Sep 2, 2016
af57b2e
Fixes for piping and display for ACLs
begoldsm Sep 2, 2016
ddadf90
Re-record other tests due to Op name change in http
begoldsm Sep 3, 2016
50d8d57
Address comments to reduce breaking changes
begoldsm Sep 6, 2016
8cc5540
Address Feedback and remove breaking changes
begoldsm Sep 6, 2016
debd087
Remove one extra line of blank comments.
begoldsm Sep 6, 2016
3c860c9
put dashes back in comment block
begoldsm Sep 6, 2016
fae3f96
Re-run all tests to make recordings happy.
begoldsm Sep 7, 2016
a916c7b
removed commented out code per review comment.
begoldsm Sep 7, 2016
dc0c7f5
updates for the ACL to be both by name and the one pipeline object.
begoldsm Sep 7, 2016
1284a74
Add should process support
begoldsm Sep 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .../DataLakeAnalytics/Commands.DataLakeAnalytics.Test/Commands.DataLakeAnalytics.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,12 @@
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Authorization.2.0.0\lib\net40\Microsoft.Azure.Management.Authorization.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Microsoft.Azure.Management.DataLake.Analytics, Version=0.11.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Analytics.0.11.5-preview\lib\net45\Microsoft.Azure.Management.DataLake.Analytics.dll</HintPath>
<Reference Include="Microsoft.Azure.Management.DataLake.Analytics, Version=0.12.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Analytics.0.12.0-preview\lib\net45\Microsoft.Azure.Management.DataLake.Analytics.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Microsoft.Azure.Management.DataLake.Store, Version=0.12.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Store.0.12.2-preview\lib\net45\Microsoft.Azure.Management.DataLake.Store.dll</HintPath>
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Store.0.12.5-preview\lib\net45\Microsoft.Azure.Management.DataLake.Store.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Microsoft.Azure.Management.ResourceManager, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
Expand Down Expand Up @@ -258,4 +256,4 @@
<ItemGroup />
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<Import Project="$(SolutionDir)\.nuget\NuGet.targets" Condition="Exists('$(SolutionDir)\.nuget\NuGet.targets')" />
</Project>
</Project>
7 changes: 3 additions & 4 deletions ...rceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands.DataLakeAnalytics.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,8 @@
<Reference Include="Microsoft.Azure.Common.NetFramework">
<HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.NetFramework.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Azure.Management.DataLake.Analytics, Version=0.11.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Analytics.0.11.5-preview\lib\net45\Microsoft.Azure.Management.DataLake.Analytics.dll</HintPath>
<Reference Include="Microsoft.Azure.Management.DataLake.Analytics, Version=0.12.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Azure.Management.DataLake.Analytics.0.12.0-preview\lib\net45\Microsoft.Azure.Management.DataLake.Analytics.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Microsoft.Azure.ResourceManager, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
Expand Down Expand Up @@ -193,4 +192,4 @@
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<Import Project="$(SolutionDir)\.nuget\NuGet.targets" Condition="Exists('$(SolutionDir)\.nuget\NuGet.targets')" />
</Project>
</Project>
2 changes: 1 addition & 1 deletion ...akeAnalytics/Commands.DataLakeAnalytics/Commands/GetAzureRmDataLakeAnalyticsDataSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class GetAzureDataLakeAnalyticsDataSource : DataLakeAnalyticsCmdletBase
{
internal const string DataLakeParameterSetName = "Get a Data Lake Store account";
internal const string BlobParameterSetName = "Get a Blob storage account";
internal const string ListStorageParameterSetName = "List a data source";
internal const string ListStorageParameterSetName = "List all data sources";

[Parameter(ValueFromPipelineByPropertyName = true, Position = 0, Mandatory = true,
ParameterSetName = DataLakeParameterSetName, HelpMessage = "Name of the account to add the data source to.")
Expand Down
5 changes: 3 additions & 2 deletions ...Analytics/Commands.DataLakeAnalytics/Commands/NewAzureRmDataLakeAnalyticsCatalogSecret.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ public class NewAzureDataLakeAnalyticsCatalogSecret : DataLakeAnalyticsCmdletBas

[Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = BaseParameterSetName, Position = 3,
Mandatory = true, HelpMessage = "The host of the database to connect to in the format 'myhost.dns.com'.")]
public string Host { get; set; }
[Alias("Host")]
public string DatabaseHost { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an alias to the previous parameter name to avoid a breakign change. Also, be sure to avoid any breaking changes in the properties of the output type for this cmdlet as well.


[Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = BaseParameterSetName, Position = 4,
Mandatory = true, HelpMessage = "The Port associated with the host for the database to connect to.")]
Expand All @@ -68,7 +69,7 @@ public override void ExecuteCmdlet()
WriteWarning(string.Format(Resources.NoPortSpecified, Uri));
}

var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", Host, Port));
var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", DatabaseHost, Port));

WriteObject(DataLakeAnalyticsClient.CreateSecret(Account, DatabaseName, Secret.UserName,
Secret.GetNetworkCredential().Password, toUse.AbsoluteUri));
Expand Down
5 changes: 3 additions & 2 deletions ...Analytics/Commands.DataLakeAnalytics/Commands/SetAzureRmDataLakeAnalyticsCatalogSecret.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ public class SetAzureDataLakeAnalyticsCatalogSecret : DataLakeAnalyticsCmdletBas

[Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = BaseParameterSetName, Position = 3,
Mandatory = true, HelpMessage = "The host of the database to connect to in the format 'myhost.dns.com'.")]
public string Host { get; set; }
[Alias("Host")]
public string DatabaseHost { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments - add an alais to prevent breaks, and beware of breaks in the output types


[Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = BaseParameterSetName, Position = 4,
Mandatory = true, HelpMessage = "The Port associated with the host for the database to connect to.")]
Expand All @@ -68,7 +69,7 @@ public override void ExecuteCmdlet()
WriteWarning(string.Format(Resources.NoPortSpecified, Uri));
}

var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", Host, Port));
var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", DatabaseHost, Port));

WriteObject(DataLakeAnalyticsClient.UpdateSecret(Account, DatabaseName, Secret.UserName,
Secret.GetNetworkCredential().Password, toUse.AbsoluteUri));
Expand Down
Loading