[Azure Site Recovery] PR contains: aligning PowerShell to service object model, supporting some new features and some bug fixes. #2912
Conversation
1) Aligning PowerShell to service object model. 2) Introducing deprecation warning for cmdlets and parameter sets to be deprecated in future. 2) HUB changes. 3) Bug Fixes.
|
@avneeshrai Hey Avneesh, please merge the latest changes from dev to fix the conflicts #Resolved |
|
@cormacpayne I have merged the latest changes from dev and resolved the conflicts. Please review and merge the PR. #Resolved |
|
@markcowl Could you please review this PR. Given its a big PR I am expecting it to take some time of yours. #Resolved |
| @@ -22,7 +22,7 @@ namespace Microsoft.Azure.Commands.SiteRecovery | |||
| /// </summary> | |||
| [Cmdlet(VerbsCommon.Remove, "AzureRmSiteRecoveryNetworkMapping")] | |||
| [OutputType(typeof(ASRJob))] | |||
| public class RemoveAzureRMSiteRecoveryNetworkMapping : SiteRecoveryCmdletBase | |||
There was a problem hiding this comment.
RemoveAzureRMSiteRecoveryNetworkMapping [](start = 17, length = 39)
Any reason the remove Networking mapping does not have SupportShouldProcess parameter? #Resolved
There was a problem hiding this comment.
We get errors from the build infra for SupportShouldProcess parameter only if cmdlet has -Force parameter. I guess if Force is not present SupportShouldProcess is not mandatory as PR build succeeds. Please let me know if thats not the case.
In reply to: 78791145 [](ancestors = 78791145)
|
Overall looks good. Let's get the tests in to get decent coverage of your feature. #Resolved |
|
Sure..i will update the PR with needed tests. In reply to: 247099534 [](ancestors = 247099534) |
|
Updated the PR after taking your comments and including new tests. In reply to: 247124518 [](ancestors = 247124518,247099534) |
[Azure Site Recovery] Commit contains: