Add script to create a build drop from a sign job #2956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcowl
requested changes
Sep 16, 2016
| $newContent[$idx + 2] = " </discoveryHint>" | ||
|
|
||
| # Change the buffer size to include the three lines just added | ||
| $buffer = 3 |
There was a problem hiding this comment.
Should we change $VSFeedSeen to false at this point?
There was a problem hiding this comment.
I thought about it, but didn't account for the case where the ordering of the file could change. That is a good idea. I will mark as false here.
| if ($PSGetSeen -and $content[$idx] -like "*msiProductCode*") | ||
| { | ||
| $content[$idx] = " <msiProductCode>$ProductCode</msiProductCode>" | ||
| } |
There was a problem hiding this comment.
Shoudl we change $PSGetSeen to false at this point?
There was a problem hiding this comment.
Same as comment for $VSFeedSeen.
| $content[$idx] = " <trackingURL>http://www.microsoft.com/web/handlers/webpi.ashx?command=incrementproddownloadcount&prodid=WindowsAzurePowershell&version=$PSVersion&prodlang=en</trackingURL>" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Should have a condition here which ends the $PSGetSeen, to make this more robust over changed orderings in the file
There was a problem hiding this comment.
Same as comment for $VSFeedSeen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
Fix for issue #2929
This script will be used for Azure PowerShell releases.
It takes the build artifacts from a sign job and creates a new entry in the shared folder that will contain the msi, packages, scripts and WebPI installers from the PSReleaseDrop folder, and other xml files used for WebPI testing.
This script will also create and push a new branch to the given CodePlex WebPI fork containing the changes to the two xml files.
This checklist is used to make sure that common issues in a pull request are covered by the creator. You can find a more complete discussion of PowerShell cmdlet best practices here.
Below in Overall Changes, check off the boxes that apply to your PR. For the categories that you did not check off, you can remove them from this body. Within each of the categories that you did select, make sure that you can check off all of the boxes.
For information on cleaning up the commits in your pull request, click here.
Overall Changes
General
Tests