Admin Export Template Image: Add Ops, TA Cmdlet and security check for exporting template image out of ARA #2963
Conversation
…r exporting template image out of ARA
…r exporting template image out of ARA
…r exporting template image out of ARA
|
Hi @arcadiahlyy, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@azuresdkci test this please |
|
Hi @arcadiahlyy, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@azuresdkci retest this please |
…r exporting template image out of ARA part 2
…r exporting template image out of ARA part 3
|
@arcadiahlyy Hey Lei, would you mind pulling from dev to get the latest changes that fix the on-demand build? |
|
@arcadiahlyy Please fix the shouldprocess implementation. If you cna do this early this morning, we may be able to take the change for this release, otherwise this will not be possible. |
…r exporting template image out of ARA
…r exporting template image out of ARA
| { | ||
| OperationResultWithTrackingId response = null; | ||
|
|
||
| if (ShouldProcess(CollectionName, "Overwrite existing template image while exporting the template image of collection")) |
There was a problem hiding this comment.
This is incorrect - every change should be protected by ShouldProcess. If there is a special condition that happens on some Exports that could result in an overwrite, if that condition exists, you should protect the change with Force | ShoudlContinue
It is not appropriate to make a processing decision that requires a user prompt, or in this case, a processing decision that happens based on the user's ConfirmationPreference setting
| { | ||
| OperationResultWithTrackingId response = null; | ||
|
|
||
| if (ShouldProcess(CollectionName, "Overwrite existing user disks while exporting user disks of collection")) |
|
LGTM once the build passes |
No description provided.